Enable additional javascript style linting rules

[ragesoss]

We're using eslint rules from several plugins — the airbnb config, plus some React plugins — to maintain fairly standard style and Javascript usage. However, we have many of the rules disabled via .eslintrc, because there were violations that appeared after an update of the eslint config.

Most of these should be re-enabled along with fixes for any violations in the codebase.

To enable a rule, you should remove the line that disables it. That will allow the plugin rules to prevail. We want to maintain as little customized eslint configuration as possible.

For reference: https://eslint.org/docs/user-guide/configuring

Please only work on a single rule at a time (with one PR per rule), and only a few rules per contributor (as it gets boring to review too many of these kinds of PRs).

[hstoebel]

I'll give this one a shot!

[hstoebel]

currently working on no-find-dom-node and forbid-prop-types

[bryszard]

Working on no-danger. See #1492

[nicktu12]

Hi there! I’m with a group of first-time contributors and was hoping to help out with this issue. I noticed nobody was assigned to it, but if there’s already a solution in progress I’m happy to try helping out elsewhere. Thanks!

[ragesoss]

@nicktu12 go for it! The a11y rules are especially appreciated, as fixing the javascript so that those rules are not violated may concretely improve the accessibility of the app.

[alpha721]

@ragesoss can I give some of these a try?

[ragesoss]

Yep!

On Feb 11, 2018 12:40 PM, "Neetu" [email protected] wrote:

@ragesoss https://github.com/ragesoss can I give some of these a try?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WikiEducationFoundation/WikiEduDashboard/issues/1408#issuecomment-364786383, or mute the thread https://github.com/notifications/unsubscribe-auth/AAzyY2BK0QTOXkW685LdYm_3P2OZhNyNks5tT1A-gaJpZM4PeJsn .

[helenatxu]

Hello, I am an applicant for the Outreachy internship, can I take this issue for my first contribution? Is it still available?

[ajitesh13]

Hello, Can I proceed with this open issue ?

[Nikuunj]

Hi @ragesoss,

I hope this message finds you well. I'm interested in joining the WikiEducationFoundation Slack channel to stay informed and contribute to the discussions. Could you please add me to the channel?

Looking forward to being a part of the community.

[utkarsh-gaur]

Hello @ragesoss , I hope you are doing well. I am willing to the WikiEducationFoundation's slack channel to keep up with latest news. It would be grateful of you if you add me to the channel.

Eagerly waiting to be a part of the discussions taking place at WikiEducationFoundation . Regards

[ragesoss]

Let me know your email address if you would like a Slack invite.

[utkarsh-gaur]

Thank you for your response. Here's my email address associated with slack. Email: @.***

On Sun, Dec 17, 2023 at 12:27 AM Sage Ross @.***> wrote:

Let me know your email address if you would like a Slack invite.

— Reply to this email directly, view it on GitHub https://github.com/WikiEducationFoundation/WikiEduDashboard/issues/1408#issuecomment-1858906882, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV4KETXMDCQOE7LLZBMLKQLYJXVIFAVCNFSM4D3YTMT2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBVHA4TANRYHAZA . You are receiving this because you commented.Message ID: @.*** com>

[utkarsh-gaur]

i want to try my hands on this issue. can you please assign this issue to me?

[ragesoss]

@utkarsh-gaur your email address did not come through on github.

[utkarsh-gaur]

E-mail: [email protected]

[fillingtothemomo]

@ragesoss I would like to work on this issue, can you please assign it to me.

[utkarsh-gaur]

@ragesoss i want to try my hands on this issue. can you please assign this issue to me?

[ragesoss]

We do not assign issues. Please read the CONTRIBUTING doc for advice on getting started.