HuskSync icon indicating copy to clipboard operation
HuskSync copied to clipboard

Adapt to Fabric and ask for contribution code-related notes.

Open hanbings opened this issue 1 year ago • 2 comments

Hello! I stumbled across this plugin and it works brilliantly! Whether it is user experience or code architecture design, thank you for your efforts! After trying to read the code, I found that the project has decoupled the relevant parts of the server. I wonder if you have an adaptation plan for Fabric? I'd like to try to do a port to Fabric, targeting servers who only use Fabric's server-side mods. If you are willing to maintain the code of Fabric, I will report the progress and adaptation and initiate a PR in the next one to two weeks.

English is not my first language, so my wording and grammar may not be very appropriate. Please forgive me and point out my mistakes. 😊

hanbings avatar Mar 31 '23 04:03 hanbings

In short, yes -- I designed HuskSync's core logic decoupled to allow for that in the future -- if you want to port to fabric and maintain it, please go right ahead and PR, that's exactly the sort of reason I make the source available for my stuff :)

Same with all my plugins, really, I'd very much be keen to add Fabric support. I actually tried doing a sponge version of Homes, just didn't get round to it yet.


There's a few complexities with Fabric you'd need to work around, namely

  • MineDown is how text is formatted, you'd need some way of converting that to whatever system fabric uses (not sure if adventure works on fabric yet)
  • Serializing user inventories on Fabric is a bit of a question mark atm

WiIIiam278 avatar Apr 04 '23 10:04 WiIIiam278

Closed by #217

WiIIiam278 avatar Dec 21 '23 17:12 WiIIiam278

Fabric support has now been merged 🎉

WiIIiam278 avatar Jun 09 '24 21:06 WiIIiam278