python-barcode icon indicating copy to clipboard operation
python-barcode copied to clipboard

Update codex.py

Open srolin opened this issue 6 years ago • 5 comments

Fixes for bug #55 writer_options{"add_checksum": False} being ignored for Code39 barcodes. Added class variable to track when the checksum has been added so it can't add twice Moved the check for checksum to the render function Set a default value class variable.

srolin avatar Oct 28 '19 01:10 srolin

render doesn't seem to modify self.code. How does the checksum end up being added twice? It would seem that it's only done in the constructor (or am I missing something?).

WhyNotHugo avatar Oct 30 '19 09:10 WhyNotHugo

render doesn't seem to modify self.code. How does the checksum end up being added twice? It would seem that it's only done in the constructor (or am I missing something?).

This was changed in the first commit. I moved the checksum code from the class constructor to the render function. The second commit was just to address your previous comments. If you look at the combined changes you can see the new render code.

srolin avatar Nov 01 '19 05:11 srolin

Sorry, I'm not seeing it. :sweat: Can you point me to the exact line where this happens? Or maybe a sample code to reproduce the issue? Or a unit test that fails for the bug?

WhyNotHugo avatar Nov 01 '19 09:11 WhyNotHugo

I think perhaps I have not explained the change very well. I am traveling at the moment, but will take some time and fully document the bug, the fix, what code breaks etc. Thanks for your patience.

srolin avatar Nov 05 '19 14:11 srolin

Hey there! Do you have any update?

WhyNotHugo avatar Feb 25 '20 00:02 WhyNotHugo