Hugo
Hugo
I did a review of that branch (I admit I didn't see it before, because I looked for keyword `VANISHED`. I only notice one difference, it uses: UID FETCH 1:*...
v2: removed a very long example from the docs. It's very easy for this to fall out of sync and not really useful.
Tests with dovecot failed. When writing these tests I didn't realise that they also run with another server in CI. I lean towards dropping the third commit— the one which...
We can also drop the incomplete imapmemserver support and enable the client-server NOTIFY tests only for dovecot. I see the `useDovecot` flag which should be useful for that. I'll wait...
v3: added test for how disconnections are handled (both with and without NOTIFY). Fix `Overflow()` channel hanging on disconnection.
I've re-written the client test to run only with dovecot, which has real NOTIFY support. Those test will be skipped with the imapmemserver, but are a lot more meaningful than...
~~I've added another commit (which probably needs to be squashed later) which allows recognising whether a NOTIFY stream ended because of an explicit NOTIFICATIONOVERFLOW or because the connection closed.~~ I...
All comments addressed; ready for a second round of review.
Tests were verbose, but I originally preferred to keep them that way since they're at least straightforward without too many clever abstractions. TableDrivenTests is much shorter and even simpler to...
How do you expect todoman to handle VJOURNAL entries? They seem like different kind of files—I think a separate tool to operate on them might be best. See also: https://sr.ht/~marcc/agendafs/