goldsmith.nvim icon indicating copy to clipboard operation
goldsmith.nvim copied to clipboard

Investigate improving startup time

Open WhoIsSethDaniel opened this issue 2 years ago • 5 comments

Startup time is slow. The reason is obvious: a lot of checking for tools and retrieving information about them. This can and should be done asynchronously.

WhoIsSethDaniel avatar May 29 '22 00:05 WhoIsSethDaniel

How slow are you thinking here? For me, using lunarvim, my startup time is almost 10s - if I disable goldsmith it drops to some hundreds of milliseconds.

It seem that this is due to some recent change (although it could of course be due to changes to my system config).

seanrmurphy avatar Jun 25 '22 10:06 seanrmurphy

I don't see anything that bad. The worst startup time I've observed is just under 2s. I ran :GoInstallBinaries and the startup time improved to just over 1s. I'd be very interested to know what is causing a 10s (!) startup time.

WhoIsSethDaniel avatar Jun 25 '22 15:06 WhoIsSethDaniel

So it seems to be something to do with the upgrade to go version 1.18 - when I downgrade to go 1.17, startup time is slightly over 1s, but upgrading again to go 1.18 (1.18.3 specifically) it was taking over 8s.

I guess it's prob somehow an issue with my go configuration. Hmm....

seanrmurphy avatar Jun 26 '22 07:06 seanrmurphy

Did you re-run :GoInstallBinaries? I am using 1.18.3 and my startup is slow, but nothing like 8s.

WhoIsSethDaniel avatar Jun 27 '22 16:06 WhoIsSethDaniel

:GoInstallBinaries should print the error when an error occurs. I'll look into doing that.

WhoIsSethDaniel avatar Jun 27 '22 22:06 WhoIsSethDaniel

Startup seems improved by recent PR #61

WhoIsSethDaniel avatar Sep 03 '22 03:09 WhoIsSethDaniel