whs.js should we remove the object from this.children ?

should we remove the object from this.children ?

Open BrookShuihuaLee opened this issue 6 years ago • 7 comments

https://github.com/WhitestormJS/whs.js/blob/591f4b4fe60d95336f3dae1fca1b1ff6ce605cc6/src/modules/app/SceneModule.js#L47

Apr 24 '18 07:04 BrookShuihuaLee

i find that the element in app.children will never be removed. is this a bug?

Apr 24 '18 09:04 BrookShuihuaLee

@hirako2000

Apr 24 '18 09:04 BrookShuihuaLee

Good question, I don't tend to use children; @sasha240100 would answer you.

Apr 24 '18 09:04 hirako2000

thank you @hirako2000 . so, do you think this is a bug ? @sasha240100

Apr 24 '18 09:04 BrookShuihuaLee

same as https://github.com/WhitestormJS/whs.js/blob/591f4b4fe60d95336f3dae1fca1b1ff6ce605cc6/src/core/Component.js#L181

Apr 24 '18 10:04 BrookShuihuaLee

@BrookShuihuaLee A bug, true. Really thankful that you found it! Would be glad to see a PR from you:)

Apr 24 '18 18:04 sasha240100

ok, i'll try it later.

Apr 25 '18 01:04 BrookShuihuaLee