A Module for Wagner PostEffects

[sasha240100]

Wagner has lots of cool post-processing effects and shaders. I'd like to see them implemented as a module for App.

Concept

const app = new WHS.App([
  // ...
  new WagnerModule([
    new WAGNER.ZoomBlurPass(),
    new WAGNER.MultiPassBloomPass()
  ])
])

• [ ] Working concept.
• [ ] Support for advanced passes.

And methods:

• [ ] .addPass(pass) - adds pass to composer.
• [ ] .removePass(passName) - removes pass.
• [ ] .togglePass(passName) - I'd like to see this feature. Turns on/off the pass

Version:

• [x] v2.x.x
• [ ] v1.x.x

Issue type:

• [ ] Bug
• [x] Proposal/Enhancement
• [ ] Question

---

Tested on:

Desktop

• [ ] Chrome
• [ ] Chrome Canary
• [ ] Chrome dev-channel
• [ ] Firefox
• [ ] Opera
• [ ] Microsoft IE
• [ ] Microsoft Edge

Android

• [ ] Chrome
• [ ] Firefox
• [ ] Opera

IOS

• [ ] Chrome
• [ ] Firefox
• [ ] Opera

[thejmazz]

Instead, maybe abstract it so PP passes can take in fragment shader code

As opposed to defining a key in some module for all these passes

[thejmazz]

However, looking at wagner API, maybe I spoke too soon

[sasha240100]

@thejmazz It has a lot of effects that we can use. Already implemented! i like that. So simple

[thejmazz]

the source of our current PostProcessorModule is very similar to that of Wagner. I suspect ours came from THREE.EffectComposer, which Wagner is built on. Might be worthwhile to deprecate PostProcessorModule and have a wagner module instead.

[sasha240100]

@thejmazz If we can compare the code. I mean which implementation is better - yes, let's do that. I want to have a simpler and more flexible implementation. Also consider adding .togglePass() option.

I also have some more ideas in mind that we can add. Some kind of transitions between passes.

[edwinwebb]

Wagner looks like a complex extension of the EffectComposer. WHS has a pretty much 1:1 port. Still seems to swap a couple of RenderTargets but has been extended with a bunch of extra functions to accommodate the complexities of the bundled filters.

The Wagner bundled filters don't seem to rely on any masking or depth rendering techniques which makes things a lot more simple.

I'd say these filters can be wrapped and delivered with WHS using the current post-processor.

[sasha240100]

@edwinwebb So current PostProcessorModule can replace a possible WagnerModule? Could you do a test, please?

[edwinwebb]

I'll see what I can do. I've a day job so it's hard to find time for open source. I've been working on something similar here which I hope can provide some shortcuts : https://github.com/edwinwebb/three-seed/blob/master/app/Renderer/EffectRenderer.js

[hirako2000]

is that superseeded with stuff you did with postprocessing @sasha240100 ?

[noahcoetsee]

@sasha240100 I know this is another old Issue, but I'd like to help out with this as well. Since you and hirako are so busy with the editor, I'll be over here maintaining the project :D

[sasha240100]

Nice! We now moved to another postprocessing module, but let’s see if we could support Wagner as well

On Fri, Mar 2, 2018 at 4:24 PM Noah [email protected] wrote:

@sasha240100 https://github.com/sasha240100 I know this is another old Issue, but I'd like to help out with this as well. Since you and hirako are so busy with the editor, I'll be over here maintaining the project :D

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WhitestormJS/whs.js/issues/191#issuecomment-369934005, or mute the thread https://github.com/notifications/unsubscribe-auth/AHTX1R03QIvoNkd4iQhVMzNj0l0zqWy8ks5taVYFgaJpZM4Maoqf .

[noahcoetsee]

Awesome! What PP module are you on now?

[sasha240100]

Take a look at PostProcessorModule in sources

On Fri, Mar 2, 2018 at 6:09 PM Noah [email protected] wrote:

Awesome! What PP module are you on now?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WhitestormJS/whs.js/issues/191#issuecomment-369966361, or mute the thread https://github.com/notifications/unsubscribe-auth/AHTX1d-uF3OsX9xqYXRGZAx4epMafa7Bks5taW5kgaJpZM4Maoqf .

[noahcoetsee]

Alright! Also: I do need some help with the Networking Module. I'll discord you about it later!

[sasha240100]

Sounds good. Ping me there

On Fri, Mar 2, 2018 at 8:49 PM Noah [email protected] wrote:

Alright! Also: I do need some help with the Networking Module. I'll discord you about it later!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/WhitestormJS/whs.js/issues/191#issuecomment-370016160, or mute the thread https://github.com/notifications/unsubscribe-auth/AHTX1UTSakCrrbnAD8RJWsrVISw_-YSZks5taZQWgaJpZM4Maoqf .