Parser-PHP icon indicating copy to clipboard operation
Parser-PHP copied to clipboard

Published 20 hours ago • verified publisher icon WhichBrowser

New Bot Additions

Open vincentkoc opened this issue 6 years ago • 4 comments

  • SEO Moz.com Roger Bot
  • SEO Majestic SEO Bot
  • HTTPUnit for Java

vincentkoc avatar Jan 19 '19 06:01 vincentkoc

Coverage Status

Coverage remained the same at 99.976% when pulling 2ebfbc629626847025da0ea96d4cbab56f87a1c6 on koconder:dev-newbots into 9c6ad8eadc23294b1c66d92876c11f13c5d4cf48 on WhichBrowser:master.

coveralls avatar Jan 19 '19 06:01 coveralls

My apologies for not responding earlier. If a PR change the detection, it also need to be accompanied with tests. That way we can ensure that the change will keep working in the future.

NielsLeenheer avatar Dec 08 '19 20:12 NielsLeenheer

@NielsLeenheer this is to help patch an issue from a dependency to this library. Its almost a year old, could you help with the unit tests?

vincentkoc avatar Dec 25 '19 06:12 vincentkoc

I already added Moz and Majestic I could create a new pr for the HTTPUnit for Java

@NielsLeenheer you might as well close this pr and I will create a new pr for the HTTPUnit for Java tomorrow for you.

summercms avatar Aug 19 '20 22:08 summercms