stickers icon indicating copy to clipboard operation
stickers copied to clipboard

PackValidator, iOS AppStore domain

Open thisIsTheFoxe opened this issue 4 years ago • 5 comments

https://github.com/WhatsApp/stickers/blob/94ecae8394775056857f3450cb52222ae36b93a3/Android/app/src/main/java/com/example/samplestickerapp/StickerPackValidator.java#L45 https://github.com/WhatsApp/stickers/blob/94ecae8394775056857f3450cb52222ae36b93a3/Android/app/src/main/java/com/example/samplestickerapp/StickerPackValidator.java#L84

Is there a specific reason it requires an itunes.apple.com domain? Afaik, the correct way to link an iOS app is via the apps.apple.com domain. And yes, it is still working and will give you an HTTP/2 301 redirect to apps.apple.com. But then again, why use the redirect when you could just use the normal address right away?

thisIsTheFoxe avatar Feb 22 '21 20:02 thisIsTheFoxe

Will fix.

simonzhexu avatar Feb 23 '21 19:02 simonzhexu

To be fair, both domains should be accepted.

MarsVard avatar Feb 23 '21 22:02 MarsVard

yep.

To be fair, both domains should be accepted.

simonzhexu avatar Feb 26 '21 01:02 simonzhexu

I think we need to first fix WhatsApp to accept both domains, then after most clients upgrade, then change the domain on this repo, otherwise, WhatsApp will reject apps.apple.com

This process would probably take 3 months, in the meantime, I ask you bear with the incorrectness. Sorry.

simonzhexu avatar Feb 26 '21 01:02 simonzhexu

I think the domain was itunes.apple.com, but then changed to apps.apple.com.

simonzhexu avatar Feb 26 '21 01:02 simonzhexu