stickers icon indicating copy to clipboard operation
stickers copied to clipboard

Added tool for create JSON for content.json file

Open pratikbutani opened this issue 5 years ago • 28 comments

I have created tool which is helpful to generate JSON by uploading images and other details. Now it will be easy to create JSON for developers. Enjoy!

pratikbutani avatar Feb 27 '19 05:02 pratikbutani

PS: This resolves #406

MarvinJWendt avatar Feb 27 '19 10:02 MarvinJWendt

@simonzhexu @amrit-1901 Need to update anything?

pratikbutani avatar Mar 04 '19 04:03 pratikbutani

@pratikbutani Give it time :) Somebody will look at it and if you need to make any changes you will get notified 👍

MarvinJWendt avatar Mar 04 '19 14:03 MarvinJWendt

@MarvinJWendt Here I published article : JSON Creator for WhatsApp Sticker Pack

pratikbutani avatar Mar 05 '19 05:03 pratikbutani

Hi @pratikbutani and @MarvinJWendt, thank you. Sorry for the delay. Now I am back. This is great work! I tried it out, it works great!

One thing I want to suggest and you can help, is to add some validation logic. For example, all the URLs need to start with http or https the sticker pack folder name/identifier needs to have no space and follow this requirement:

  • identifier: The identifier should be unique and can be alphanumeric: a-z, A-Z, 0-9, and the following characters are also allowed "_", "-", "." and " ". The identifier should be less than 128 characters.

You can also add in your form to let them input the "android_play_store_link" and "ios_app_store_link": "",

I will need to discuss this with some other team members before I can merge this. Give me a few days.

Again, this is great work! Thank you!

simonzhexu avatar Mar 13 '19 21:03 simonzhexu

For sure, @simonzhexu I will update as you said.

Thank you so much @Zandor300 for approve pull request. <3

Many thanks to @MarvinJWendt for your motivation. :+1:

Hopefully it will be merged soon. Thanks again.

pratikbutani avatar Mar 18 '19 10:03 pratikbutani

Hi, @pratikbutani , unfortunately, I cannot approve this merge request, as we are not allowed to link to a third party website that may change at any time for the security of developers. I know this may come as a disappointment and I am very sorry.

You are welcome to promote your json generator on your own website and through other channels.

One thing that would work is creating some sort of script that can be run on the repo that can look at the assets folder and create a json file, something like a python script or shell script. The script would be on the repo and we can review it.

simonzhexu avatar Mar 19 '19 00:03 simonzhexu

Hey @simonzhexu, as you mentioned that it would be possible to add a script to the repo:

The tool created by @pratikbutani is actually a single html file (link). Wouldn't it be possible to add that to the stickers repo? The users/developers would have a nice GUI. There would be some changes that @pratikbutani would have to do tho.. For example, we should remove the donation button then, as I guess that WhatsApp cannot ask for donations. And probably the assets should directly be in the html file, so that it works offline.

But I think this could be a solution, as the file would directly be owned by WhatsApp. I would say that html files provide a better user experience, especially for new developers who don't have much experience with scripting languages as python or shell.

Obviously that would require some changes to the html code, so that it fits with all WhatsApp guidelines.

Just a thought.. :)

MarvinJWendt avatar Mar 19 '19 08:03 MarvinJWendt

Hi, @pratikbutani , unfortunately, I cannot approve this merge request, as we are not allowed to link to a third party website that may change at any time for the security of developers. I know this may come as a disappointment and I am very sorry.

You are welcome to promote your json generator on your own website and through other channels.

One thing that would work is creating some sort of script that can be run on the repo that can look at the assets folder and create a json file, something like a python script or shell script. The script would be on the repo and we can review it.

Basically I am android developer having good experience to make apps but never tried to make anything in web. This is my first try just because I got the issue to make JSON with all packs. Its tough and time wasting process to make json.

I have just put efforts to make very light and simple tool so developer can use it.

It would be great inspiration for me that I make it successfully.

Thanks for everything.

pratikbutani avatar Mar 19 '19 09:03 pratikbutani

Hey @simonzhexu, as you mentioned that it would be possible to add a script to the repo:

The tool created by @pratikbutani is actually a single html file (link). Wouldn't it be possible to add that to the stickers repo? The users/developers would have a nice GUI. There would be some changes that @pratikbutani would have to do tho.. For example, we should remove the donation button then, as I guess that WhatsApp cannot ask for donations. And probably the assets should directly be in the html file, so that it works offline.

But I think this could be a solution, as the file would directly be owned by WhatsApp. I would say that html files provide a better user experience, especially for new developers who don't have much experience with scripting languages as python or shell.

Obviously that would require some changes to the html code, so that it fits with all WhatsApp guidelines.

Just a thought.. :)

Thank you for your support. If I need to do any changes then I will.

pratikbutani avatar Mar 19 '19 09:03 pratikbutani

Hey @simonzhexu, as you mentioned that it would be possible to add a script to the repo:

The tool created by @pratikbutani is actually a single html file (link). Wouldn't it be possible to add that to the stickers repo? The users/developers would have a nice GUI. There would be some changes that @pratikbutani would have to do tho.. For example, we should remove the donation button then, as I guess that WhatsApp cannot ask for donations. And probably the assets should directly be in the html file, so that it works offline.

But I think this could be a solution, as the file would directly be owned by WhatsApp. I would say that html files provide a better user experience, especially for new developers who don't have much experience with scripting languages as python or shell.

Obviously that would require some changes to the html code, so that it fits with all WhatsApp guidelines.

Just a thought.. :) Hi @pratikbutani , I want to pick up this conversation. Sorry, the thoughts have been lost out of the cracks. I think if we can add the html code into the repo itself and let developers run on their own, ,as @MarvinJWendt suggested. I can merge it in. Are you willing to do some work and make some improvements to the HTML?

simonzhexu avatar May 01 '20 15:05 simonzhexu

Yeah sure, Do let me know what are changes that I have to do? @simonzhexu

pratikbutani avatar May 01 '20 15:05 pratikbutani

Sounds great, I will circle back to you on more details. Really appreciate what you did.

simonzhexu avatar May 01 '20 17:05 simonzhexu

Sounds great, I will circle back to you on more details. Really appreciate what you did.

Any changes?

pratikbutani avatar May 07 '20 06:05 pratikbutani

I am working with partnerships team to figure out how to work with you. @pratikbutani , please stay tuned.

simonzhexu avatar May 11 '20 22:05 simonzhexu

I am working with partnerships team to figure out how to work with you. @pratikbutani , please stay tuned.

Hello @simonzhexu Is there any changes that I can do? Any update from your side?

pratikbutani avatar Jun 25 '20 14:06 pratikbutani

@simonzhexu @MarvinJWendt

Greetings!

What should I do change in JSON Generator to make GIF supported JSON?

pratikbutani avatar Jul 10 '20 06:07 pratikbutani

@simonzhexu @MarvinJWendt

Greetings!

What should I do change in JSON Generator to make GIF supported JSON?

@simonzhexu @MarvinJWendt Do let me know what to do?

pratikbutani avatar Feb 06 '21 05:02 pratikbutani

I am working with partnerships team to figure out how to work with you. @pratikbutani , please stay tuned.

Do let me know what we can do together?

pratikbutani avatar Mar 24 '21 06:03 pratikbutani

@simonzhexu @MarvinJWendt I am eagerly waiting for your response. Do let me know what I need to changes?

pratikbutani avatar Apr 20 '21 15:04 pratikbutani

Hi @pratikbutani it would be nice to be able to let people run the script inside the repo without going to a website, what I am thinking is, perhaps, we create html page inside this repo and have all the logic inside this repo. User click on the html page inside the repo, and perform the JSON generation, then the html page puts the JSON into the contents.json file.

simonzhexu avatar Apr 20 '21 19:04 simonzhexu

This is a great project and really love your work. Sorry for the late response.

simonzhexu avatar Apr 20 '21 19:04 simonzhexu

Hi @pratikbutani it would be nice to be able to let people run the script inside the repo without going to a website, what I am thinking is, perhaps, we create html page inside this repo and have all the logic inside this repo. User click on the html page inside the repo, and perform the JSON generation, then the html page puts the JSON into the contents.json file.

Yeah that will be also good. Do let me know what to do further?

pratikbutani avatar Apr 21 '21 04:04 pratikbutani

@pratikbutani , I think the ask from our side is to perform the JSON generation entirely inside this repo without having any code going out to external websites. Do you think it is doable?

simonzhexu avatar May 10 '21 20:05 simonzhexu

@pratikbutani , I think the ask from our side is to perform the JSON generation entirely inside this repo without having any code going out to external websites. Do you think it is doable?

Yes we can do that also. We can put this HTML file inside the repo and open as web link.

pratikbutani avatar Jul 19 '21 13:07 pratikbutani

Sounds good. @pratikbutani . Could you update this PR and include all HTML files in the repo? Thank you so much!

simonzhexu avatar Dec 30 '21 20:12 simonzhexu

@simonzhexu @BlackGengar Uploaded Zip File. Please take a look.

WAStickerApp-JSON-Generator-master.zip

Do let me know if any changes required.

pratikbutani avatar Sep 30 '22 12:09 pratikbutani

Do let me know if I need to change anything here. I will be happy to help.

pratikbutani avatar Jul 14 '23 05:07 pratikbutani