proxy icon indicating copy to clipboard operation
proxy copied to clipboard

Add minor fixes to Helm chart templates

Open arashn opened this issue 3 years ago • 5 comments

Fixed minor issues in Helm template files that caused installation to fail.

arashn avatar Jan 07 '23 23:01 arashn

Hi @arashn!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Jan 07 '23 23:01 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jan 08 '23 01:01 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Jan 08 '23 01:01 facebook-github-bot

Thanks for your contribution! Please bump the chart version, to say 1.0.1 since it's a nearly irrelevant edit. Then push an update. Signals should then be clean.

slawlor avatar Jan 09 '23 16:01 slawlor

Chart version has been updated

arashn avatar Jan 09 '23 16:01 arashn