Westbrook Johnson

Results 527 comments of Westbrook Johnson

For those that are interested, my version of this plugin looks as follows with the new exports: ```ts import type { Middleware, MiddlewareState } from '@floating-ui/dom'; import { getContainingBlock, getWindow,...

This is our current version of the plugin in Typescript: ```ts import type { Middleware, MiddlewareState } from '@floating-ui/dom'; import { getContainingBlock, getWindow, isContainingBlock, } from '@floating-ui/utils/dom'; import { VirtualTrigger...

Practically, it’s this https://github.com/adobe/spectrum-web-components/blob/main/packages/overlay/src/VirtualTrigger.ts However, if you never use [virtual elements](https://floating-ui.com/docs/virtual-elements) then you could omit that gating.

I can look to get it cleaned up and go from there. However, if this is a "bug" and with the larger amount of interaction with the overall element stack,...

We still intend to work on this. It is indeed quite important, but seemingly not important enough for any of our consuming teams to push for it to be prioritized...

No longer occurring with `v1.4.3` of `lit-plugin`.

We'll be surfacing `--swc-overlay-z-index-base` as a custom property to outline the floor of the Overlay stack when AND ONLY WHEN the stack is being delivered in a _fallback_ context. When...

@hunterloftis can you review whether there are still things we'd like updated in regards to this?

Within the context of this, we support what is spec'd in Spectrum, for better or worse.