pyvis
pyvis copied to clipboard
Do not load external bootstrap resources for cdn_resources = 'in_line' | 'local'
The cdn_resources option should control how external resources and stylesheets should be loaded.
Currently bootstrap is being fetched from CDN irrespective of the cdn_resources option.
Also I have observed some inconsistencies in the local option where the vis-network css and js files are not being taken from the lib folder but rather externally fetched. Please correct me here if my understanding of how these options are intended to work is wrong.
To summarise the changes:
- fetch bootstrap from CDN when
cdn_resources = 'remote' - use resources from
lib/whencdn_resources = 'local' - remove the double heading (which is also being fixed in #191)
- run
example.ipynbto update the samples
Do you need anything from my side for validating the checksums? @BerserkerGaruk
@BerserkerGaruk @summerswallow-whi , I have rebased the branch to resolve the merge conflicts that occurred in the meantime. I would appreciate it, if you could take a look, since the MR is open for a couple of month now
Is there anything that could be done to help with this?
I had verified e2e this change on my offline code with in_line, it worked like a charm
cc @summerswallow-whi @BerserkerGaruk
Thanks!