pyvis icon indicating copy to clipboard operation
pyvis copied to clipboard

Do not load external bootstrap resources for cdn_resources = 'in_line' | 'local'

Open FieteO opened this issue 2 years ago • 4 comments

The cdn_resources option should control how external resources and stylesheets should be loaded. Currently bootstrap is being fetched from CDN irrespective of the cdn_resources option.

Also I have observed some inconsistencies in the local option where the vis-network css and js files are not being taken from the lib folder but rather externally fetched. Please correct me here if my understanding of how these options are intended to work is wrong.

To summarise the changes:

  • fetch bootstrap from CDN when cdn_resources = 'remote'
  • use resources from lib/ when cdn_resources = 'local'
  • remove the double heading (which is also being fixed in #191)
  • run example.ipynb to update the samples

FieteO avatar Dec 28 '22 18:12 FieteO

Do you need anything from my side for validating the checksums? @BerserkerGaruk

FieteO avatar Jan 19 '23 09:01 FieteO

@BerserkerGaruk @summerswallow-whi , I have rebased the branch to resolve the merge conflicts that occurred in the meantime. I would appreciate it, if you could take a look, since the MR is open for a couple of month now

FieteO avatar Mar 14 '23 21:03 FieteO

Is there anything that could be done to help with this?

fohrloop avatar May 03 '23 07:05 fohrloop

I had verified e2e this change on my offline code with in_line, it worked like a charm

cc @summerswallow-whi @BerserkerGaruk

Thanks!

wey-gu avatar Apr 01 '24 05:04 wey-gu