pyvis icon indicating copy to clipboard operation
pyvis copied to clipboard

Fixed conflicts for experimental branch PR

Open mrceresa opened this issue 2 years ago • 2 comments

Dear friends, thanks a lot for this beautiful package!

I was interested in the experimental branch features that is discussed here in #85 and in #91 but there were some conflicts due to the time that passed between the two branches. I tried to reconcile them and now they could be merged.

I run all the tests and they pass and I was also able to run all the cells in the example notebook. Also the utils.js library now loads correctly in the browser.

I'm not sure if I was able to import all the features but at least it highlight the nodes and show the selection menu.

Once I select the nodes the color of the others stays grey and do not reset.

Best,

Mario

mrceresa avatar Apr 20 '22 14:04 mrceresa

Can you add some test cases and a Jupyter notebook for this so I can see the changes?

jhunpingco avatar Apr 20 '22 19:04 jhunpingco

Dear Jose, this is simply a fix of the merge errors of the other PR, named "Experimental".

You can find a notebook here, but it is the same as the other, cheers

Mario

ExampleSelection.zip pyvis_experimental_selection

mrceresa avatar Jun 23 '22 09:06 mrceresa