t20-Dash_Well_Viz
t20-Dash_Well_Viz copied to clipboard
WesleyTheGeolien
Heroku
Branch that deploys to heroku https://t20-dash-well-viz.herokuapp.com/
@kinverarity1 I had to modify the setup.py, tbh I don't use them too often it would be good if you could check out the 2 lines I deleted and see if they are necessary or not for other things?
Did the pre-existing setup.py break the heroku deployment? They are both relatively "new" additions to setuptools. So I can revert it back to older ways of handling the packaging, not a big deal.
It's ok for now just won't work for tagging the version on pypi deployment. Installing from source should be fine.
Sent from Outlook Mobilehttps://aka.ms/blhgte
From: Wesley Banfield [email protected] Sent: Sunday, June 14, 2020 9:20:31 PM To: WesleyTheGeolien/t20-Dash_Well_Viz [email protected] Cc: Kent Inverarity [email protected]; Mention [email protected] Subject: Re: [WesleyTheGeolien/t20-Dash_Well_Viz] Heroku (#44)
@WesleyTheGeolien commented on this pull request.
Did the pre-existing setup.py break the heroku deployment? They are both relatively "new" additions to setuptools. So I can revert it back to older ways of handling the packaging, not a big deal.
@kinverarity1https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkinverarity1&data=02%7C01%7C%7Cdeee0d80a481450e06be08d810592492%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637277322343101247&sdata=V0KkDqYSy4XiFL2wlhCOia6FHBSbLMNpFhJALHDDVdk%3D&reserved=0 Yep, but the version of setup.py in this branch works, does this setup seem reasonable to you? or do things need to be changed?
setup_requires=["setuptools_scm"],
description="Tools for Transform 2020 Dash_Well_Viz project",
long_description=open("README.md", "r").read(),
- long_description_content_type="text/markdown",
I think this was just a warning @kinverarity1https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkinverarity1&data=02%7C01%7C%7Cdeee0d80a481450e06be08d810592492%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637277322343111240&sdata=nqTzaQHm5QkKJDNRhFAB74EmHOGChFg5yCq6IAFngwM%3D&reserved=0
@@ -2,11 +2,9 @@
setup( name="dashwellviz",
- use_scm_version=True,
pretty sure this was the line breaking the heroku builds @kinverarity1https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fkinverarity1&data=02%7C01%7C%7Cdeee0d80a481450e06be08d810592492%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637277322343121235&sdata=W%2FTtVYuleTcC5kALpdyDrQiiEdCi8DBkqRZ56QuaX4Q%3D&reserved=0
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FWesleyTheGeolien%2Ft20-Dash_Well_Viz%2Fpull%2F44%23pullrequestreview-430169280&data=02%7C01%7C%7Cdeee0d80a481450e06be08d810592492%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637277322343121235&sdata=9DUW%2FGP49%2BgHfAETZFsbQ2JNbdoJa%2B6rWwS7%2BSUDFvk%3D&reserved=0, or unsubscribehttps://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABCQ623NZBK7FO4KK5WV2CTRWS2QPANCNFSM4N5EZ6IA&data=02%7C01%7C%7Cdeee0d80a481450e06be08d810592492%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637277322343121235&sdata=SVPL8fx776ejk7l2YU%2BmDugkIb4VeyS4z8fNAQ0Np88%3D&reserved=0.
Hmm maybe it's the runtime then if you say it is new? This is using python 3.6.10 do you think upgrading to 3.8 would help?
Not sure, it's a setuptools feature. Maybe just remove and change to version='0.1.0' i.e. manual versioning
Sent from Outlook Mobilehttps://aka.ms/blhgte
From: Wesley Banfield [email protected] Sent: Sunday, June 14, 2020 9:35:52 PM To: WesleyTheGeolien/t20-Dash_Well_Viz [email protected] Cc: Kent Inverarity [email protected]; Mention [email protected] Subject: Re: [WesleyTheGeolien/t20-Dash_Well_Viz] Heroku (#44)
Hmm maybe it's the runtime then if you say it is new? This is using python 3.6.10 do you think upgrading to 3.8 would help?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://eur06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FWesleyTheGeolien%2Ft20-Dash_Well_Viz%2Fpull%2F44%23issuecomment-643757580&data=02%7C01%7C%7Cdf345b045ba84a8d359808d8105b494f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637277331546531794&sdata=GJ9%2FdyUkYXTWvmlZwqStX4Vy8KHQfXOH6hQ0ptzEwYA%3D&reserved=0, or unsubscribehttps://eur06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABCQ626LPYBSWCNIPNDNQADRWS4KBANCNFSM4N5EZ6IA&data=02%7C01%7C%7Cdf345b045ba84a8d359808d8105b494f%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637277331546541790&sdata=pCbgQ38P3vuS9oZIdCAJ9nDTUyqCSeRbCUn1qOexDC8%3D&reserved=0.
@kinverarity1 I have tried updating the runtime to python 3.8.3 and reintroducing the lines I removed. As suspected the long_description_content_type worked fine but the use_scm_version broke the deploy .... here is the log if it makes sense to you:
-----> Python app detected
-----> No change in requirements detected, installing from cache
-----> Installing SQLite3
-----> Installing requirements with pip
Obtaining file:///tmp/build_20a9a9147a4c3fe45eaa36792e22ea85 (from -r /tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/requirements.txt (line 5))
ERROR: Command errored out with exit status 1:
command: /app/.heroku/python/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/setup.py'"'"'; __file__='"'"'/tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info
cwd: /tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/
Complete output (27 lines):
/app/.heroku/python/lib/python3.8/distutils/dist.py:274: UserWarning: Unknown distribution option: 'long_description_content_type'
warnings.warn(msg)
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/setup.py", line 3, in <module>
setup(
File "/app/.heroku/python/lib/python3.8/site-packages/setuptools/__init__.py", line 129, in setup
return distutils.core.setup(**attrs)
File "/app/.heroku/python/lib/python3.8/distutils/core.py", line 108, in setup
_setup_distribution = dist = klass(attrs)
File "/app/.heroku/python/lib/python3.8/site-packages/setuptools/dist.py", line 372, in __init__
_Distribution.__init__(self, attrs)
File "/app/.heroku/python/lib/python3.8/distutils/dist.py", line 292, in __init__
self.finalize_options()
File "/app/.heroku/python/lib/python3.8/site-packages/setuptools/dist.py", line 528, in finalize_options
ep.load()(self, ep.name, value)
File "/tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/.eggs/setuptools_scm-4.1.2-py3.8.egg/setuptools_scm/integration.py", line 17, in version_keyword
dist.metadata.version = _get_version(config)
File "/tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/.eggs/setuptools_scm-4.1.2-py3.8.egg/setuptools_scm/__init__.py", line 148, in _get_version
parsed_version = _do_parse(config)
File "/tmp/build_20a9a9147a4c3fe45eaa36792e22ea85/.eggs/setuptools_scm-4.1.2-py3.8.egg/setuptools_scm/__init__.py", line 110, in _do_parse
raise LookupError(
LookupError: setuptools-scm was unable to detect version for '/tmp/build_20a9a9147a4c3fe45eaa36792e22ea85'.
Make sure you're either building from a fully intact git repository or PyPI tarballs. Most other sources (such as GitHub's tarballs, a git checkout without the .git folder) don't contain the necessary metadata and will not work.
For example, if you're using pip, instead of https://github.com/user/proj/archive/master.zip use git+https://github.com/user/proj.git#egg=proj
----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
! Push rejected, failed to compile Python app.
! Push failed```