ServerCore icon indicating copy to clipboard operation
ServerCore copied to clipboard

Missing `excluded_entity_types` on 1.3.6 for 1.19.2 Forge

Open jmadarg opened this issue 1 year ago • 4 comments

Describe the bug The config for excluded_entity_types for the Activation Range optimization is missing, so we can't exclude some entities that need to be able to work, like Minecolonies' colonists or visitors putting this here for when its needed again servercore minecolonies (minecolonies:citizen, minecolonies:visitor)

Reproduce

  • Add v1.3.6 Servercore
  • Let it generate a config file
  • Config file will not have the desired option

Expected behavior Have the option to include entities

Versions -Latest is not a version! ServerCore: 1.3.6 Minecraft: Forge 1.19.2

Mod incompatibilities Maybe Minecolonies? It's always been a bit of a headache to allow it's citizen's to work when activation range is enabled

jmadarg avatar Oct 02 '24 21:10 jmadarg

Oop, accidentally pressed enter, let me finish editing the issue

EDIT: Done! Sorry for the problems, always a hassle to do thing from a phone

jmadarg avatar Oct 02 '24 21:10 jmadarg

I don't think this config setting existed in 1.3.5 either (I believe it was added in 1.3.7?), so makes sense if its not there. 1.3.6 for 1.19.2 isn't really a new version, its only some needed hotfixes on top of an old version of the mod. Though I prefer to drop support for 1.19.2 at this point it should be fairly trivial to add, so I might look into it once I have the time (and a working pc again)

Wesley1808 avatar Oct 02 '24 22:10 Wesley1808

Completely understandable! We previously used that option in 1.20.1 servers, I just kinda assumed it also existed on 1.19.2

I would really appreciate it if the option could be ported, this is an awesome mod! A must have!

jmadarg avatar Oct 02 '24 22:10 jmadarg

We should be able to blacklist the mod itself, instead of having to try to find out all the possible entity types for X mod, to make it work.

inactive_tick_entity_blacklist:
  - "minecolonies:citizen"
  - "minecolonies:guard"
  - "minecolonies:visitor"
  - "minecolonies:mercenary"
  - "minecolonies:raider"

much better if we have something like:

inactive_tick_entity_blacklist:
  - "minecolonies:*"

or

inactive_tick_mod_blacklist:
  - "minecolonies:*"
  - "minecoloni_addon"

pwaksman973 avatar Sep 07 '25 23:09 pwaksman973