laravel-validated-dto icon indicating copy to clipboard operation
laravel-validated-dto copied to clipboard

Published 20 hours ago • verified publisher icon WendellAdriel

Fixing issue 100 - Exception: Serialization of 'Closure' is not allow…

Open patriziotomato opened this issue 9 months ago • 8 comments

…ed #100

patriziotomato avatar Feb 10 '25 18:02 patriziotomato

@patriziotomato changes seem ok to me! ✅ Thanks for the help on that! 🔥 Just make sure to run the linter so the checks can pass! 💪

WendellAdriel avatar Feb 11 '25 11:02 WendellAdriel

@WendellAdriel Did run docker compose run --rm app composer lint but it hasn't changed any file. Any idea why?

patriziotomato avatar Feb 12 '25 08:02 patriziotomato

@WendellAdriel Did run docker compose run --rm app composer lint but it hasn't changed any file. Any idea why?

That's interesting, can you just try one more thing, if that doesn't work I'll accept the PR and run it on my end. Try removing your vendor folder and running the make install command

WendellAdriel avatar Feb 12 '25 10:02 WendellAdriel

@WendellAdriel Did run docker compose run --rm app composer lint but it hasn't changed any file. Any idea why?

That's interesting, can you just try one more thing, if that doesn't work I'll accept the PR and run it on my end. Try removing your vendor folder and running the make install command

That made it. Not sure if you want to have this pushed into that project, but I added it to my PR.

I also added a test now and still don't get it, why here my linter is just fine, while it fails in Github Actions. Any idea for hat @WendellAdriel ?

patriziotomato avatar Feb 17 '25 08:02 patriziotomato

@WendellAdriel Did run docker compose run --rm app composer lint but it hasn't changed any file. Any idea why?

That's interesting, can you just try one more thing, if that doesn't work I'll accept the PR and run it on my end. Try removing your vendor folder and running the make install command

That made it. Not sure if you want to have this pushed into that project, but I added it to my PR.

I also added a test now and still don't get it, why here my linter is just fine, while it fails in Github Actions. Any idea for hat @WendellAdriel ?

Have you tried running the rm -rf vendor && make install command to see if it changes anything for the linter?

WendellAdriel avatar Feb 24 '25 10:02 WendellAdriel

@patriziotomato can you update the PR to be updated with the latest version released, please?

WendellAdriel avatar Mar 03 '25 12:03 WendellAdriel

docker compose run --rm app composer lint

Unfortunately still same result. I rebased the branch, so that it is up-to-date...

patriziotomato avatar Mar 03 '25 13:03 patriziotomato

docker compose run --rm app composer lint

Unfortunately still same result. I rebased the branch, so that it is up-to-date...

Weird that it seems to be running the "old" actions because I dropped the support and tests from Laravel 9 and 10 and PHP 8.1 and it's still showing those runs for the actions. 😢

Can you try to create a new branch from the main one and create a new PR with the changes, please?

WendellAdriel avatar Mar 03 '25 13:03 WendellAdriel

@patriziotomato sorry for the delay on this. I have pushed a fix for this so I'll be closing this PR.

WendellAdriel avatar Jun 19 '25 14:06 WendellAdriel