webstone-plugins icon indicating copy to clipboard operation
webstone-plugins copied to clipboard

Don't rely on the `npm_execpath` env variable to determine which package manager to use

Open mikenikles opened this issue 2 years ago • 2 comments

The npm_execpath env variable isn't set if you install the package manager in a way other than npm i -g [yarn|pnpm].

This PR just checks if pnpm --version or yarn --version successfully runs. If so, it picks whichever command didn't fail. If both commands fail, we fall back to NPM.

mikenikles avatar Nov 05 '22 22:11 mikenikles

🦋 Changeset detected

Latest commit: a14abd8ebee636b329008a0b8bb05f956a74737a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@webstone/cli Minor
@webstone/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Nov 05 '22 22:11 changeset-bot[bot]

Julian, "This is only needed the very first time we create a Webstone app/plugin. Any other time, we can determine the package manager based on the available lock file."

mikenikles avatar Nov 11 '22 18:11 mikenikles