webstone-plugins icon indicating copy to clipboard operation
webstone-plugins copied to clipboard

Published 20 hours ago • verified publisher icon WebstoneHQ

Use Rollup for bundling

Open Cahllagerfeld opened this issue 2 years ago • 2 comments

Bundles the output to use rollup

By using a bundler we can get rid of these suspect .js imports in our typescript files

It's maybe worth checking the esbuild-plugin for rollup

Cahllagerfeld avatar Jul 18 '22 21:07 Cahllagerfeld

⚠️ No Changeset found

Latest commit: 02cac8b6d90eb50b58e0cee826c60786e2f74177

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 18 '22 21:07 changeset-bot[bot]

Snapshot for using esbuild plugin with rollup

Cahllagerfeld avatar Jul 19 '22 19:07 Cahllagerfeld

affected by #236. Ideally we use esbuild for bundling. This would mean that rollup isn't required

Cahllagerfeld avatar Sep 11 '22 18:09 Cahllagerfeld

closing this in favor of #238

Cahllagerfeld avatar Sep 15 '22 19:09 Cahllagerfeld