Damselfly icon indicating copy to clipboard operation
Damselfly copied to clipboard

Image orientation not being honoured for image

Open Webreaper opened this issue 1 year ago • 10 comments

Per @marijnv2000 : File is too big to attach here.. See google drive link: https://drive.google.com/file/d/1Tz6MqP_AWPCO5x7Yc1AC8eXbhLmwNLR6/view?usp=sharing

exiftool shows "Rotate 270 CW". Local image viewers open it up with the correct orientation, damselfly shows it sideways like this:

image

Webreaper avatar Apr 29 '24 06:04 Webreaper

Looks like a SkiaSharp bug. I've reported it here: https://github.com/mono/SkiaSharp/issues/2850

Webreaper avatar Apr 30 '24 09:04 Webreaper

I''ve put in a temporary fix, which should solve your issue. @marijnv2000 can you pull webreaper/damselfly:dev and see if it solves it?

Webreaper avatar May 01 '24 05:05 Webreaper

@Webreaper sorry, took a while for me to get back to this. Thanks for looking into this.

I've changed to dev and it still doesn't rotate the image, neither in the thumbnail or when viewing the image. It does look to have solved the stretching issue for the thumbnail however, it now looks like this: image

By the way, I'm happy to wait for the SkiaSharp issue to be fixed.

marijnv2000 avatar May 06 '24 14:05 marijnv2000

Did you refresh the thumbnails via the context menu? They won't be regenerated unless you do. It works fine for me.

Webreaper avatar May 06 '24 14:05 Webreaper

Yes, I did. Twice now :) Same result in the browser and the app, which I guess is expected, but still. Not rotated

marijnv2000 avatar May 06 '24 15:05 marijnv2000

One other thing to try is pressing shift+refresh in the browser. It could be browser caching.

Webreaper avatar May 06 '24 15:05 Webreaper

Tried clearing cookies and site data for the domain, tried force refresh, tried private mode, tried a different browser that had never opened Damselfly before, and get the same result on all..

marijnv2000 avatar May 06 '24 15:05 marijnv2000

Dammit. Weird, wonder how it works for me?

Webreaper avatar May 06 '24 15:05 Webreaper

Weird indeed.. Any way to verify we're running the same code? I pulled the dev tag and saw some changes (notably the + on folder icons letting me expand/collapse them) so I assumed it worked correctly.

marijnv2000 avatar May 06 '24 15:05 marijnv2000

Definitely running the same code. I always run dev.

Possibly an OS thing, I haven't tried it on linux.

Webreaper avatar May 06 '24 16:05 Webreaper