Damselfly icon indicating copy to clipboard operation
Damselfly copied to clipboard

Only 250 images are loaded

Open ronbruins opened this issue 1 year ago • 5 comments

When opening a folder with a large amount (>250) it shows 250 images and spinning circle, like it is loading the remaining ones.

ronbruins avatar Sep 15 '23 09:09 ronbruins

I have tested it some more and some unexpected behaviour presented itself, however is a workaround by itself :-)

When the thumbs are smallest Screenshot 2023-09-15 at 12 54 51 Medium It gets stuck at 250 and a spinning circle...

When changing the size that needs to scroll and scrolling down, it will load the additional images. Then returning to the small thumb page it shows all images:

Screenshot 2023-09-15 at 12 57 09 Medium

ronbruins avatar Sep 15 '23 09:09 ronbruins

It's implemented as virtual scrolling. The way it should work is that when you scroll the last image on-screen, the next lot should load. Is your screen so big that all 250 load and fit on screen? If you make the browser smaller does the scrolling then work?

It might be I need to tweak so that if you're on a huge monitor, it auto-loads more if the last image is already visible in the viewport.

Webreaper avatar Sep 15 '23 11:09 Webreaper

Hi,

Yeah, iMac 5k :-) Indeed when I decrease browser it does the scrolling, this also made sense as when I enlarge the thumbs, as the also go outside the window

I’ll use that for the moment, Thanks

On 15 Sep 2023, at 14:21, Mark Otway @.***> wrote:

It's implemented as virtual scrolling. The way it should work is that when you scroll the last image on-screen, the next lot should load. Is your screen so big that all 250 load and fit on screen? If you make the browser smaller does the scrolling then work?

It might be I need to tweak so that if you're on a huge monitor, it auto-loads more if the last image is already visible in the viewport.

— Reply to this email directly, view it on GitHub https://github.com/Webreaper/Damselfly/issues/492#issuecomment-1721109791, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKN7XFJFADQO6QB7IUOBFGLX2Q24BANCNFSM6AAAAAA4ZRMK5Q. You are receiving this because you authored the thread.

ronbruins avatar Sep 15 '23 13:09 ronbruins

Okay, thanks. Looks like I need to buy a bigger screen 'for testing'. ;)

Will look at putting in a fix. :)

Webreaper avatar Sep 15 '23 13:09 Webreaper

Okay, long time coming, but I think I have a fix for this.... to try it you'll need to pull webreaper/damselfly:dev - and you may need to shift-refresh your browser to ensure the latest javascript loads. Let me know if it does the trick.

Webreaper avatar Apr 16 '24 12:04 Webreaper