Damselfly icon indicating copy to clipboard operation
Damselfly copied to clipboard

Error when attempting to tag a face identified as "Unidentified"

Open whoopn opened this issue 2 years ago • 6 comments

Error: System.NullReferenceException: Arg_NullReferenceException at Damselfly.Web.Client.Shared.Dialogs.NameDialog.OnInitialized() at Microsoft.AspNetCore.Components.ComponentBase.RunInitAndSetParametersAsync()

Happens when I click on the "Unidentified Face".

Damselfly v4.0.2.

Is there a setting I need to turn on?

whoopn avatar Dec 11 '22 23:12 whoopn

Think it's just a bug - investigating....

Webreaper avatar Dec 12 '22 07:12 Webreaper

Can you try pulling webreaper/damselfly:dev and see if that stops the exception?

Webreaper avatar Dec 12 '22 08:12 Webreaper

It takes a while for the dev to get where the non-dev is. The filter for tagged faces also seems like it doesn't filter right (or I dont know how to use it). I'll let you know if it resolves it.

whoopn avatar Dec 17 '22 23:12 whoopn

Same error:

System.NullReferenceException: Arg_NullReferenceException at Damselfly.Web.Client.Shared.Dialogs.NameDialog.OnInitialized() at Microsoft.AspNetCore.Components.ComponentBase.RunInitAndSetParametersAsync()

Damselfly-20221217.log

whoopn avatar Dec 18 '22 03:12 whoopn

I tested this in develop branch and it was still throwing an exception in UpdateName in ImageRecognitionService. A few lines below I see:

if (faceObject.Person == null)
{
        faceObject.Person = new Person();
        db.People.Add(faceObject.Person);
}

So I am assuming the exception is a mistake? I created a pull request #465 to address this, and it now works for me. Nice work btw!

dhthwy avatar Jan 02 '23 21:01 dhthwy

Exception is indeed a mistake. Good spot - thanks for fixing! :)

Webreaper avatar Jan 03 '23 10:01 Webreaper