weblate icon indicating copy to clipboard operation
weblate copied to clipboard

Browse mode for power users: add keyboard arrows for going forward, and back while browsing

Open alltheseas opened this issue 2 years ago โ€ข 8 comments

Describe the problem

what happens

When "browsing" all strings for a particular language, in an application translated in Weblate, I don't have a quick way to go to the next page of strings. When I browse to the bottom of the page, I cannot easily proceed to the next page. I have to

  1. scroll back to the top of the page, and
  2. click on the right arrow icon

Describe the solution you'd like

what I suggest should happen

When browsing all strings of translations with multiple pages of strings, I should be able to use the arrows on my keyboard to move forward to the next page (right arrow), and move back to the previous page (left arrow).

This will save me time, and reduce friction while browsing all strings for a particular language.

Describe alternatives you've considered

Keep suffering

Screenshots

No response

Additional context

No response

alltheseas avatar Sep 18 '23 18:09 alltheseas

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

github-actions[bot] avatar Sep 26 '23 12:09 github-actions[bot]

Hey @alltheseas!

This is my first time contributing to open-source and also participating in Hacktoberfest. My tech stack is : HTML, CSS, JS & React (intermediate).

Can you assign me this issue?

Also, pls guide me during the process of fixing this issue๐Ÿ™

varunTarone avatar Sep 30 '23 12:09 varunTarone

Welcome to FOSS @varunTarone !

I do not have permissions for this repository. Maybe @nijel can help.

If we don't hear back, consider yourself assigned!

Lmk if you have questions

alltheseas avatar Sep 30 '23 17:09 alltheseas

Awesome! So meanwhile, I was searching through the codebase (still searching), but I was unable to find the exact code where the feature needs to be implemented. Can u also share your slack so that we can discuss how should I step by step solve this issue and what change need to be done in the code ๐Ÿ˜ƒ Plus should I use this installation method for contribution: https://docs.weblate.org/en/latest/admin/install/source.html#installing-from-sources or simply Docker.

Also I will tag @nijel so that he can assign me this issue and provide some help regarding it.

Thank You ๐Ÿ‘‹

varunTarone avatar Oct 01 '23 09:10 varunTarone

searching through the codebase (still searching), but I was unable to find the exact code where the feature needs to be implemented.

Did you find where the front and back arrows for navigating forward and back are?

slack

I'm a new contributor here - try tagging the owners of this repo

alltheseas avatar Oct 01 '23 14:10 alltheseas

Live chat about Weblate is available at Libera.Chat IRC network. The channel name is #weblate. This can be accessed by, for example, https://web.libera.chat/#weblate or an IRC client installed on your computer.

alltheseas avatar Oct 01 '23 15:10 alltheseas

searching through the codebase (still searching), but I was unable to find the exact code where the feature needs to be implemented.

Did you find where the front and back arrows for navigating forward and back are?

slack

I'm a new contributor here - try tagging the owners of this repo

Oh ok, understood ๐Ÿ‘ am on it. And also, sorry for distributing you again ๐Ÿ™ And thank you for the help.

varunTarone avatar Oct 02 '23 03:10 varunTarone

Weblate currently uses Mousetrap to bind keyboard shortcuts:

https://github.com/WeblateOrg/weblate/blob/1576de13c4faef59286279c9e493a116d722bafb/weblate/static/editor/full.js#L85-L88

A similar script needs to be implemented for the browse page and documented: https://docs.weblate.org/en/latest/user/translating.html#keyboard-shortcuts

Having https://github.com/WeblateOrg/weblate/issues/5064 implemented as well would be nice to show users what keyboard shortcuts are available on the current page.

nijel avatar Jun 25 '24 07:06 nijel

I've started working on this issue. I will add the key bindings with the RIGHT and LEFT arrows to control navigation. And mention them in the docs. Then show them in the shortcuts modal (@nijel I am not sure where that is exactly and how to bring it up).

meel-hd avatar Jul 18 '24 10:07 meel-hd

Great to see somebody picking this! I'd recommend leaving out https://github.com/WeblateOrg/weblate/issues/5064 as a separate pull request as it is a separate issue and changes will be then easier to review.

nijel avatar Jul 18 '24 12:07 nijel

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, donโ€™t hesitate to support Weblate by making a donation.

github-actions[bot] avatar Jul 19 '24 12:07 github-actions[bot]

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, donโ€™t hesitate to support Weblate by making a donation.

github-actions[bot] avatar Jul 19 '24 12:07 github-actions[bot]