weblate icon indicating copy to clipboard operation
weblate copied to clipboard

Replace misaka with mistletoe

Open nijel opened this issue 1 year ago • 9 comments

Describe the problem

mistletoe is used for parsing Markdown in translate-toolkit so it is requirement we can not avoid. misaka is used internally by Weblate. So there are now two Markdown parsers required to run Weblate.

Describe the solution you'd like

Replace usage of misaka with mistletoe. It should not be hard, our customization is pretty minimal: https://github.com/WeblateOrg/weblate/blob/main/weblate/utils/markdown.py

Describe alternatives you've considered

No response

Screenshots

No response

Additional context

https://github.com/FSX/misaka:

Misaka is not being maintained anymore. I've not been able to find time to to properly maintain this project

nijel avatar Aug 21 '23 10:08 nijel

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

github-actions[bot] avatar Aug 21 '23 10:08 github-actions[bot]

Hello!I'd like to contribute to this

itlallou avatar Aug 23 '23 20:08 itlallou

@itlallou You're welcome!

nijel avatar Aug 23 '23 20:08 nijel

@nijel Hey this has been open for 3 weeks. So I am taking this and coming up with a PR.

subhajit20 avatar Sep 14 '23 09:09 subhajit20

You are welcome!

nijel avatar Sep 14 '23 10:09 nijel

@nijel Made a pr. Can you check and let me know for further corrections needed?

subhajit20 avatar Sep 14 '23 10:09 subhajit20

Look at https://github.com/miyuchina/mistletoe documentation and reimplement existing behavior using it.

nijel avatar Sep 14 '23 11:09 nijel

@nijel if @subhajit20 is not working on this issue i would like to work on it

Maddy0027 avatar Oct 03 '23 15:10 Maddy0027

@nijel if @subhajit20 is not working on this issue i would like to work on it

You are welcome to make a new PR by yourself. Just mention this issue in the description, so it will get linked here.

JanMalte avatar Oct 04 '23 19:10 JanMalte

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

github-actions[bot] avatar Jun 25 '24 11:06 github-actions[bot]