weblate
weblate copied to clipboard
Replace misaka with mistletoe
Describe the problem
mistletoe is used for parsing Markdown in translate-toolkit so it is requirement we can not avoid. misaka is used internally by Weblate. So there are now two Markdown parsers required to run Weblate.
Describe the solution you'd like
Replace usage of misaka with mistletoe. It should not be hard, our customization is pretty minimal: https://github.com/WeblateOrg/weblate/blob/main/weblate/utils/markdown.py
Describe alternatives you've considered
No response
Screenshots
No response
Additional context
https://github.com/FSX/misaka:
Misaka is not being maintained anymore. I've not been able to find time to to properly maintain this project
This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.
You can learn about how to get started in our contributors documentation.
Hello!I'd like to contribute to this
@itlallou You're welcome!
@nijel Hey this has been open for 3 weeks. So I am taking this and coming up with a PR.
You are welcome!
@nijel Made a pr. Can you check and let me know for further corrections needed?
Look at https://github.com/miyuchina/mistletoe documentation and reimplement existing behavior using it.
@nijel if @subhajit20 is not working on this issue i would like to work on it
@nijel if @subhajit20 is not working on this issue i would like to work on it
You are welcome to make a new PR by yourself. Just mention this issue in the description, so it will get linked here.
Thank you for your report; the issue you have reported has just been fixed.
- In case you see a problem with the fix, please comment on this issue.
- In case you see a similar problem, please open a separate issue.
- If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.