weblate
weblate copied to clipboard
When trying to add a suggestion that is == current translation, it says "suggestion already exists", even if there are actually none
Describe the issue
Sounds nitpicky, but it confused me when is was editing glossary since there's an "Explanation" text area which is in place of where the translation text area usually is on non-glossary items. Maybe this also needs to be changed.
I already tried
- [X] I've read and searched the documentation.
- [X] I've searched for similar issues in this repository.
Steps to reproduce the behavior
No response
Expected behavior
No response
Screenshots
No response
Exception traceback
No response
How do you run Weblate?
weblate.org service
Weblate versions
No response
Weblate deploy checks
No response
Additional context
Code:
https://github.com/WeblateOrg/weblate/blob/4b2e079b80103364292464b585186943b7172890/weblate/trans/views/edit.py#L288-L297
https://github.com/WeblateOrg/weblate/blob/d92daadd0e3cd8d150cb1386e9a7b3ed541f37c3/weblate/trans/models/suggestion.py#L47-L48
This issue has been automatically marked as stale because there wasn’t any recent activity.
It will be closed soon if no further action occurs.
Thank you for your contributions!
This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.
You can learn about how to get started in our contributors documentation.
hey I'm new to opensource and would like to work on it can you please tell what needs to be done?
What is it that you don't understand? There are links to the responsible code in the issue description.
I did check out the code what i meant to ask is do you have any idea on what should be changed and what should it rather say?
The problem is that there is same error message used for case where suggestion matches existing suggestion (where it correct) and when it matches existing translation (where the message is confusing).