weblate icon indicating copy to clipboard operation
weblate copied to clipboard

Jumping to a specific page through pagination component in changes page would clear the date filter

Open Geeyun-JY3 opened this issue 2 years ago • 3 comments

Describe the issue

Entering number to jump to a specific page through pagination component in changes page would clear the date filter, including starting date and ending date filter.

I already tried

  • [X] I've read and searched the documentation.
  • [X] I've searched for similar issues in this repository.

Steps to reproduce the behavior

  1. Go to changes page
  2. Setting a date filter
  3. Click on the pagination component
  4. Enter a number than go
  5. The date filter is cleared

Expected behavior

The date filter wouldn't be cleared.

Screenshots

weblate_pagination1

Exception traceback

No response

How do you run Weblate?

weblate.org service

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

Geeyun-JY3 avatar Dec 02 '21 13:12 Geeyun-JY3

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

github-actions[bot] avatar Dec 03 '21 13:12 github-actions[bot]

Hi, I would like to take this issue to start contributing to your project.

ejgonzalez17 avatar Dec 18 '21 23:12 ejgonzalez17

@ejgonzalez17 you are welcome

nijel avatar Dec 19 '21 05:12 nijel

This bug seems fixed after https://github.com/WeblateOrg/weblate/commit/08a5c15c20d15a785b1bb67d070d8eece5e61c6b (?) implemented.

Geeyun-JY3 avatar Aug 24 '23 06:08 Geeyun-JY3

Indeed it was fixed.

nijel avatar Aug 24 '23 14:08 nijel

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

github-actions[bot] avatar Aug 24 '23 14:08 github-actions[bot]