weblate icon indicating copy to clipboard operation
weblate copied to clipboard

Better digest and changed string e-mail layout

Open comradekingu opened this issue 4 years ago • 7 comments

Papercut Something ala bilde vs bilde

Right now it isn't super clear which string "Show" actually will display, since it isn't inline. Also, there isn't any separation between source and translation, so that part could be improved.

Having the user-selected alternative languages would be a bonus, since that is what I am used to looking at. More errors could be found then too.

comradekingu avatar Feb 17 '21 02:02 comradekingu

As long as the fields themselves are clickable, I don't see a need for the "Show" (Vis) button. Instead each text-field could be clickable, whether ones alternative languages are included or not.

bilde

bilde

comradekingu avatar Feb 18 '21 16:02 comradekingu

I've added digest rendering as an option to changes view in a7c2507980b369d891ad76360c8b8f64c3e4e6d1. This makes it easier to improve the rendering while developing, just append &digest=1 to any /changes/ view to see the list of changes rendered as diget e-mail.

nijel avatar Jul 24 '24 07:07 nijel

Right now there are more issues with the digest view:

obrazek

Especially the navigation is rendered as an ordered list, this is probably caused by switching to generic navigation while introducing categories, the CSS needs to be adjusted here.

nijel avatar Jul 24 '24 07:07 nijel

I am working on this. I will fix the UI alignment in the digest view. @nijel can you confirm if that is the main issue now?

meel-hd avatar Jul 24 '24 10:07 meel-hd

There are really more issues with the e-mail CSS, check yourself at https://hosted.weblate.org/changes/browse/weblate/application/cs/?digest=1 and compare it to https://hosted.weblate.org/changes/browse/weblate/application/cs/.

The e-mail rendering uses a separate CSS: https://github.com/WeblateOrg/weblate/blob/a96a13d41add9155ccfa89bf11268c14118ad761/weblate/templates/mail/style.css#L1-L461 which is then inlined: https://github.com/WeblateOrg/weblate/blob/a96a13d41add9155ccfa89bf11268c14118ad761/weblate/templates/mail/base.html#L12-L16

It can't use the full CSS we use on the website, as that won't work in the e-mail clients. I'm not sure if there is some guidance on that, but I did some manual testing in Gmail, Live, Thunderbird and Evolution to verify it looks reasonable. Since then, the e-mail content got more complex (digest feature is newer than that) and the CSS was not properly updated to cover that.

nijel avatar Aug 01 '24 09:08 nijel

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

github-actions[bot] avatar Aug 08 '24 06:08 github-actions[bot]

While #12122 makes the rendering slightly better, it doesn't fully address the issues we have with e-mail rendering, reopening.

nijel avatar Aug 08 '24 06:08 nijel

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

github-actions[bot] avatar Sep 03 '24 13:09 github-actions[bot]

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

github-actions[bot] avatar Sep 03 '24 13:09 github-actions[bot]