weblate icon indicating copy to clipboard operation
weblate copied to clipboard

Include usernames in translator credits

Open dumbmoron opened this issue 1 year ago • 7 comments

Describe the problem

Currently, the output for translator credits includes the translator's email, name, and change count.

Describe the solution you would like

It would be useful for me for automatic translation attribution if the output also included the account username of the translator.

Describe alternatives you have considered

It would probably be possible to pull out the username through some incantation of API calls, but it's not ideal considering this endpoint already has access to this information, and simply omits it.

dumbmoron avatar Oct 16 '24 19:10 dumbmoron

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

github-actions[bot] avatar Oct 17 '24 05:10 github-actions[bot]

Hi @nijel ,Can I take up this issue ?

YukeHuang123 avatar Oct 17 '24 06:10 YukeHuang123

Hi @nijel would be glad to take this up

notanshb avatar Oct 17 '24 06:10 notanshb

Hello, I would like to work on this issue.

Humayun-23 avatar Oct 17 '24 09:10 Humayun-23

Anybody is welcome to submit a pull request. The credits generating code is here:

https://github.com/WeblateOrg/weblate/blob/c8ecca099f75a110d8b8953356fc1be66c1a315a/weblate/trans/views/reports.py#L52-L92

nijel avatar Oct 18 '24 11:10 nijel

account username of the translator.

Hi @nijel, I’m encountering difficulties with the tests related to author usernames in the generate_credits function. The ReportsTest are failing, and I’m unsure why. Specifically, is the author_username field being used correctly to retrieve the username? Here is my implement on this issue: image

Thank you for your help!

YukeHuang123 avatar Oct 19 '24 14:10 YukeHuang123

Hi guys, check my PR #12821 for this issue.

harriebird avatar Oct 20 '24 03:10 harriebird

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

github-actions[bot] avatar Nov 02 '24 11:11 github-actions[bot]