weblate icon indicating copy to clipboard operation
weblate copied to clipboard

Fix latest changes UI overlapping in Insights

Open meel-hd opened this issue 1 year ago • 4 comments

Proposed changes

Fixed the Mobile UI overlapping in Latest Changes image

Closes: #12247

Checklist

  • [x] Lint and unit tests pass locally with my changes.
  • [x] I have added tests that prove my fix is effective or that my feature works.
  • [x] I have added documentation to describe my feature.
  • [x] I have squashed my commits into logic units.
  • [x] I have described the changes in the commit messages.

Other information

meel-hd avatar Aug 12 '24 16:08 meel-hd

While Latest Additions in Insights is fixed now on mobile. The History tab in Insights have the same issue of UI overlapping on mobile. image I am working on it.

Edit: It seems it is working fine. as it uses the same template as the one used by latest changes.

  • one question tough, what is the difference between history and latest changes in the Insights tab? they both have the same title of "changes"

History tab preview with the fix: image

meel-hd avatar Aug 13 '24 10:08 meel-hd

I'm starting to consider whether this is actually the correct direction. It really looks like a pop-up overlapping the user avatar and not really bound to the record. I will try to come up with something different here looking more like a toolbar (something like GitHub has when writing a comment).

nijel avatar Aug 13 '24 17:08 nijel

c31f610 proposes this layout on mobile ⬇️ image

meel-hd avatar Aug 14 '24 04:08 meel-hd

Comments and History Preview

https://github.com/user-attachments/assets/20dce3b0-3894-4587-b03e-f7e60a10623d

meel-hd avatar Aug 14 '24 05:08 meel-hd