weblate icon indicating copy to clipboard operation
weblate copied to clipboard

component: Improve duplication of components

Open ParthS007 opened this issue 2 years ago • 3 comments

WIP

Proposed changes

closes #10896

Checklist

  • [x] Lint and unit tests pass locally with my changes.
  • [x] I have tested that my improvement is effective and works.
  • [x] I have added documentation to describe my feature.
  • [x] I have squashed my commits into logic units.
  • [x] I have described the changes in the commit messages.

Duplicate Functionality in Dropdown

Screenshot 2024-05-10 at 11 13 14

Pre-selected Component in dropdown Screenshot 2024-05-29 at 12 27 13

ParthS007 avatar Feb 22 '24 23:02 ParthS007

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.74%. Comparing base (6aee586) to head (57bf259). Report is 353 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11079      +/-   ##
==========================================
- Coverage   90.82%   90.74%   -0.08%     
==========================================
  Files         554      559       +5     
  Lines       57306    57618     +312     
  Branches     9122     9200      +78     
==========================================
+ Hits        52046    52285     +239     
- Misses       3640     3696      +56     
- Partials     1620     1637      +17     
Files Coverage Δ
weblate/trans/views/create.py 88.95% <ø> (ø)

... and 58 files with indirect coverage changes

codecov[bot] avatar Feb 23 '24 01:02 codecov[bot]

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions[bot] avatar Apr 11 '24 01:04 github-actions[bot]

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions[bot] avatar Jul 19 '24 01:07 github-actions[bot]

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions[bot] avatar Sep 12 '24 01:09 github-actions[bot]

Walkthrough

The recent update introduces a feature that enhances the duplication process of components by allowing automatic cloning of additional settings, specifically in the :ref:transsection. It also adds a link in the component management interface for users to duplicate components directly. Additionally, several new fields are added to the form'sMeta` class for improved metadata handling, and the testing utilities are enhanced to support category creation. Lastly, modifications in the component selection process ensure relevant attributes from the duplicated component are preserved.

Changes

Files Change Summary
docs/changes.rst Added a section on automatic duplication of more settings during component cloning and updated :ref:subscriptions` for compatibility with password managers.
weblate/templates/component.html Added a link for users to duplicate an existing component directly in the HTML template.
weblate/trans/forms.py Introduced new fields in the Meta class to handle additional metadata related to language translation processes.
weblate/trans/tests/utils.py Added a method to create a test category and modified a function to ensure components are associated with a category.
weblate/trans/views/create.py Enhanced the CreateComponentSelection class to support component duplication, including fetching and preserving relevant attributes from the duplicated component.

Assessment against linked issues

Objective Addressed Explanation
Make duplication of components more discoverable (Issue #10896)
Duplicate key settings from the source component (Issue #10896)
Improve user interface for component duplication (Issue #10896) No visual indicators or icons were added.

Possibly related PRs

  • #12469: This PR involves modifications to weblate/trans/forms.py, which overlaps with the current PR regarding component management functionality.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 12 '24 01:09 coderabbitai[bot]