weblate icon indicating copy to clipboard operation
weblate copied to clipboard

Posix lowercase is not avaiable for Chinese

Open ZiYueCommentary opened this issue 1 year ago • 3 comments

Describe the issue

As #9377 described, Posix lowercase is the format that Minecraft uses.

According to the source code, this function was implemented by lower the code from EXPAND_LANGS. But zh_cn, zh_tw, etc are not included in it, they are included in LEGACY_CODES, so they are ignored. For example, Chinese Simplified is zh_hans instead of zh_cn.

I already tried

  • [X] I've read and searched the documentation.
  • [X] I've searched for similar filed issues in this repository.

Steps to reproduce the behavior

  1. Set Language code style as "POSIX style using underscore as a separator, including country code (lowercase)".
  2. Add Chinese Simplified or Chinese Traditional for the component.

Expected behavior

The file name of Chinese Simplified should be zh_cn, Chinese Traditional should be zh_tw, and so on.

Screenshots

No response

Exception traceback

No response

How do you run Weblate?

Docker container

Weblate versions

No response

Weblate deploy checks

No response

Additional context

No response

ZiYueCommentary avatar Jan 28 '24 14:01 ZiYueCommentary

Yes, POSIX uses codes like zh_Hant, Linux translates it to zh_TW. So, maybe you actually need Linux lowercase?

nijel avatar Jan 30 '24 14:01 nijel

So, maybe you actually need Linux lowercase?

I think yeah. There is no style that matches Minecraft.

ZiYueCommentary avatar Jan 30 '24 15:01 ZiYueCommentary

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

github-actions[bot] avatar Feb 01 '24 04:02 github-actions[bot]

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

github-actions[bot] avatar Apr 25 '24 12:04 github-actions[bot]