weblate icon indicating copy to clipboard operation
weblate copied to clipboard

Adding grant revoke admin endpoints

Open nidhi-kala opened this issue 2 years ago • 4 comments

Addressing #10222

This PR will add API endpoints for granting and revoking admin rights. I have added tests for the endpoints.

Checklist

  • [x] Lint and unit tests pass locally with my changes.
  • [x] I have added tests that prove my fix is effective or that my feature works.
  • [ ] I have added documentation to describe my feature.
  • [x] I have described the changes in the commit messages.

nidhi-kala avatar Oct 27 '23 18:10 nidhi-kala

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.66%. Comparing base (6aee586) to head (064cbd6). Report is 909 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10292      +/-   ##
==========================================
- Coverage   90.82%   90.66%   -0.16%     
==========================================
  Files         554      561       +7     
  Lines       57306    57957     +651     
  Branches     9122     9260     +138     
==========================================
+ Hits        52046    52548     +502     
- Misses       3640     3746     +106     
- Partials     1620     1663      +43     
Files Coverage Δ
weblate/api/tests.py 100.00% <100.00%> (ø)
weblate/api/views.py 90.00% <100.00%> (+0.46%) :arrow_up:
weblate/auth/permissions.py 89.01% <100.00%> (+0.08%) :arrow_up:

... and 203 files with indirect coverage changes

codecov[bot] avatar Oct 27 '23 21:10 codecov[bot]

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions[bot] avatar Dec 07 '23 01:12 github-actions[bot]

Thank you for guiding me @nijel ! I have made the naming consistent for grant and revoke admin endpoints and updated the tests.

nidhi-kala avatar Dec 15 '23 23:12 nidhi-kala

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions[bot] avatar Jan 15 '24 01:01 github-actions[bot]

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions[bot] avatar Mar 15 '24 01:03 github-actions[bot]