WIP: Improve IMAP response handling

[szymekjanaczek]

According to #270

I know, we still have to update legacy protocol. It's just a draft.

[Webklex]

Hi @szymekjanaczek , wow thanks for taking the time! I have only two questions:

• Why would you prefer to require ext-imap?
• Where / How are you using use function imap_last_error;?

Thanks again!

[szymekjanaczek]

Okay, removed ext-imap usage.

[szymekjanaczek]

Hi, what do you think about merging it? 👉👈

[Webklex]

Hi @szymekjanaczek , this line makes me nervous:

protected function assumedNextLine(string $start): bool {
    return str_starts_with($this->nextLine(), $start);
}

This would lock the code to require php > 8. I'm having an inner discussion how I should proceed. I was sure to have talked about it somewhere (but can't find it anymore). Frankly I'm nervous to exclude a whole bunch of people but I'm also aware of the fact that you can't support everything and supporting a wide range causes a whole bunch of new issues.

I haven't forgotten this pull request. In fact I thought about it a lot, I just don't know how to proceed.

Best regards,

[szymekjanaczek]

Hi @Webklex!

You're right, this must stay at the lower version of PHP - my mistake. According to the rest of your message, you probably are talking about #270, aren't you?

Greetings!

[Webklex]

Hey @szymekjanaczek , I wouldn't call it a mistake. It's a valid point to use modern functions :+1:

I've touched the topic it a little bit in 270 but that's not what I've meant.

Anyway whats your thought on it? I can see arguments for both. How would you decide?

Best regards and thanks for your help & support,

Edit: Anyone else reading this, you are welcome to share your thoughts as well :)

[szymekjanaczek]

Hello again, @Webklex

In my honest opinion we should move forward and create a new branch using PHPv8.1 with tools: sniffers, static analysis, unit tests, refactoring helpers, ci/cd on github to speed-up cooperation with new collaborators, and so on - to open the way for the further updates. And ofc some performance improvements - like using bulk IMAP operations. I know that would be a breaking change, but necessary to keep this library useable in new projects - know it from my own experience. We're using this lib in out project too.

That's my idea, now we need devs and quite advanced knowledge about IMAP usage.

Regards!

[szymekjanaczek]

Hi again @Webklex!

What do you think about merging it? Switch from mixed response to bool was a breaking change for some of my features ;(

Thanks in advance, greetings!

[Webklex]

Hi @szymekjanaczek, yes lets do it. I'll reserved the last week of the year to work on the next major release. I especially want to introduce commit testing via github actions.

Best regards,

[szymekjanaczek]

Nice to hear that - feel free to ping me when need anything!

Have a nice evening!

[Webklex]

Hi @szymekjanaczek , I just pushed my last weeks work. We now have an actual Response::class to work with and real unit tests.

Btw happy new year :)

Best regards,