php-imap icon indicating copy to clipboard operation
php-imap copied to clipboard

Published 20 hours ago • verified publisher icon Webklex

Support maintained PHP Versions & introduce Rector

Open boekkooi-lengoo opened this issue 3 years ago • 3 comments

Hello, First of thank you very much for maintaining this library! It saved me a ton of time and effort!

This PR is in bumping the support PHP version for this library to PHP 7.4 to match the currently support PHP versions (commit https://github.com/Webklex/php-imap/commit/733be54f23d07591b6679e66127a13dd38fe0c4f and https://github.com/Webklex/php-imap/commit/ae0ceb4fd289abe1f48bff524a4cc5768e14b84d).

After the PHP version update I introduced rector to help update and tweak the code based. This also involved some manual changes and I have already fix some wrong types and other things.

I understand that this PR maybe way to big but I at least wanted to share my work even if its just for inspiration. Thanks again for your work on this library!

Cheers, Warnar

boekkooi-lengoo avatar Jun 29 '22 13:06 boekkooi-lengoo

Hi @boekkooi-lengoo , wow thanks a lot for your pull request!

I'll check it out and probably merge it this weekend :)

Best regards,

Webklex avatar Jun 30 '22 10:06 Webklex

Hi @boekkooi-lengoo , I'm currently not sure about the potential implication of requiring rector. I know to little about it to blindly merge it. Especially the potential overhead. Guess I have to do some more reading.

Best regards,

Webklex avatar Jul 04 '22 02:07 Webklex

Hey @Webklex,

I totally understand and I would myself also not require Rector. I used the tool to help improve the code base automatically instead of manually. This is also the reason why I did not add a rector dry-run to the GitHub Actions workflow.

Thanks for taking the time looking at the PR :smile:

boekkooi-lengoo avatar Jul 04 '22 07:07 boekkooi-lengoo

Hi @boekkooi-lengoo , unfortunately I wasn't able to merge your pull request. However I would like to acknowledge your work and your suggestions which indeed influenced my changes. Please feel free to simply push a " " or "." - I'll happily merge it so you'll get listed as a contributor.

Best regards and a happy new year,

Webklex avatar Jan 02 '23 03:01 Webklex

Hey @Webklex,

Thanks again for looking at the PR and I'm very happy to hear that it helped you and the project. I will give the latest version of the library a test in the coming weeks and will happy contribute if I find something to improve.

Thanks again for making this library and I wish you all the best this new year.

boekkooi-lengoo avatar Jan 02 '23 05:01 boekkooi-lengoo