laravel-pdfmerger icon indicating copy to clipboard operation
laravel-pdfmerger copied to clipboard

Fixed duplexMerge page issue

Open vignesh1964 opened this issue 2 years ago • 5 comments

issue #24

Error: Cannot access protected property setasign\Fpdi\Fpdi::$page if ($duplexSafe && $oFPDI->page % 2)

Fix: changing line 249 in PDFMerger if ($duplexSafe && $oFPDI->PageNo() % 2)

vignesh1964 avatar Feb 01 '23 18:02 vignesh1964

Hi, thank you for the bugfixing pull request. It seems that the fix is related to issue #24, is that correct?

KreutzerCode avatar Feb 02 '23 16:02 KreutzerCode

Hi, thank you for the bugfixing pull request. It seems that the fix is related to issue #24, is that correct?

Hi, yes, this PR is related to issue #24

vignesh1964 avatar Feb 24 '23 11:02 vignesh1964

@KreutzerCode any chance of pulling this one in?

AdrianBav avatar Dec 06 '23 20:12 AdrianBav

@AdrianBav I would love to do that. I'm still waiting for my pull request to be checked. But I am not the maintainer of the Project. @Webklex can you indicate if you are still accepting pull requests for this repository?

KreutzerCode avatar Dec 08 '23 09:12 KreutzerCode

@Webklex Any chance you can merge this PR? Forking the repo and applying this fix was the only way to make duplexMerge work. Thx!

Heyian avatar Sep 25 '24 20:09 Heyian