sendcloud
sendcloud copied to clipboard
http-client-interface
- Rewrite to use Symfony's HTTP client and accept it as a ctor argument. Closes #43.
- Uses dedicated mock client and responses in tests and verifies URLs, methods and payloads where relevant.
symfony/http-clientis a required dependency (wide version match) because I want the library to work out of the box even if you don't inject your own client.- [ ] Requires major version change because new (autowired) client may behave differently or express different limits (memory, timing).
@linaori Could you review whether these changes would solve the issue you were experiencing? Ideally by testing with the library on this branch (composer require jouwweb/sendcloud:dev-http-client-interface), but if you see glaring problems there won't be a need for that =)
I'll see if I can squeeze in some time this or next week
Closing due to inactivity. Feel free to reopen when following up on open questions.