sendcloud icon indicating copy to clipboard operation
sendcloud copied to clipboard

http-client-interface

Open villermen opened this issue 9 months ago • 2 comments

  • Rewrite to use Symfony's HTTP client and accept it as a ctor argument. Closes #43.
  • Uses dedicated mock client and responses in tests and verifies URLs, methods and payloads where relevant.
  • symfony/http-client is a required dependency (wide version match) because I want the library to work out of the box even if you don't inject your own client.
  • [ ] Requires major version change because new (autowired) client may behave differently or express different limits (memory, timing).

villermen avatar Mar 31 '25 12:03 villermen

@linaori Could you review whether these changes would solve the issue you were experiencing? Ideally by testing with the library on this branch (composer require jouwweb/sendcloud:dev-http-client-interface), but if you see glaring problems there won't be a need for that =)

villermen avatar Apr 08 '25 18:04 villermen

I'll see if I can squeeze in some time this or next week

linaori avatar Apr 08 '25 18:04 linaori

Closing due to inactivity. Feel free to reopen when following up on open questions.

villermen avatar Aug 02 '25 20:08 villermen