hyperHTML icon indicating copy to clipboard operation
hyperHTML copied to clipboard

hyperHTML.adopt(liveNode)

Open WebReflection opened this issue 7 years ago • 1 comments

After the introduction of viperHTML.adoptable = true, capable of creating a compact and compression friendly way to delimit all interpolations of a template literals, hyperHTML would like to re-introduce this ability lost wtih v2 release because unstable.

All the basics are working but there are still two cases I cannot code cover because failing:

  • [ ] nodes with just textContent behaves differently, when text action is used the adoption shuold work properly
  • [ ] when there are levels outside those already explored, findNode(...) internal function does not handle well the level variable together with the index

Once these two outstanding bugs are fixed, I will think about releasing v3 to include adopt within the library and branch out v2 for eventual emergency fixes.

WebReflection avatar Feb 05 '18 21:02 WebReflection

Coverage Status

Coverage remained the same at ?% when pulling 4f1d747fd23f1caa7e86b865d305a37a95d20805 on re-adopt into c689e81ae0edd86ec115b584be1800045c9dd1c5 on master.

coveralls avatar Feb 27 '18 21:02 coveralls