signify-ts icon indicating copy to clipboard operation
signify-ts copied to clipboard

fix: send exn to actual recipient only

Open iFergal opened this issue 1 year ago • 2 comments

exn messages have a specific recipient (rp field).

Right now for multi-sig:

  • creates first exn message with rp field of first member
  • this message is sent to all members
  • returns early (bug in itself)

This change will just send the specific message to the specific member, and not return early.

iFergal avatar Aug 27 '24 11:08 iFergal

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.93%. Comparing base (ce3614c) to head (02f178a). Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   83.93%   83.93%           
=======================================
  Files          48       48           
  Lines        4257     4259    +2     
  Branches     1051     1038   -13     
=======================================
+ Hits         3573     3575    +2     
+ Misses        680      656   -24     
- Partials        4       28   +24     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 27 '24 11:08 codecov[bot]

ok seems to have broken 1 test, interesting.. checking

edit - ok, yes, forgot i need remove this return statement

iFergal avatar Aug 27 '24 11:08 iFergal