keripy icon indicating copy to clipboard operation
keripy copied to clipboard

Fix order of witness receipts relative to delegation approval.

Open pfeairheller opened this issue 2 years ago • 4 comments

In the current implementation of delegated inception and rotation (including in multisig delegation), the delegate controller waits for delegation approval before publishing the event to the witnesses. Since the witnesses are under the control of the controller, this order should be inverted.

To accomplish this, witnesses should accept delegated AID events without requiring a delegator approval anchor but not publish the events externally until the delegator's approval anchor is received. Once watchers are in place the witnesses can publish the event externally without the approval because the watcher's won't accept the event until the approval shows up.

pfeairheller avatar May 16 '23 18:05 pfeairheller

@pfeairheller This can be closed as it is already implemented, correct?

lenkan avatar Apr 28 '25 14:04 lenkan

No, considering the issue you just opened, it is not complete for multisig delegation and needs work there, I believe.

pfeairheller avatar Apr 28 '25 14:04 pfeairheller

I believe this can be closed once https://github.com/WebOfTrust/keripy/pull/998 is merged? That should ensure multisig delegation is working.

lenkan avatar May 15 '25 08:05 lenkan

This is fixed by https://github.com/WebOfTrust/keripy/pull/1100. Once we get that merged then we can close this issue.

kentbull avatar Nov 20 '25 22:11 kentbull