keria icon indicating copy to clipboard operation
keria copied to clipboard

fix: use exn.rp field as recipient for exchange message (#3)

Open lenkan opened this issue 1 month ago • 1 comments

All exchange messages now have the intended recipient in the payload, so the extra body parameter is confusing and could cause issues.

This PR removes the "rec" body parameter that previously specified a list of recipients of an exn message. This list had no correlation with the rp field in the exchange message payload.

This PR also removes the ipex multisig handlers, for no other reason that they weren't used in any of the signify integration tests, so to me it was unnecessary complexity. I do not see any reason to keep this feature as we already use the "/multisig/exn" from the client.

See discussions:

  • https://github.com/WebOfTrust/signify-ts/pull/267#discussion_r1642546563
  • https://github.com/WebOfTrust/keria/issues/270
  • https://github.com/WebOfTrust/signify-ts/issues/310
  • https://github.com/WebOfTrust/signify-ts/pull/311

lenkan avatar Nov 03 '25 09:11 lenkan

Codecov Report

:x: Patch coverage is 67.64706% with 22 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 84.32%. Comparing base (1f22907) to head (eed1c22). :warning: Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/keria/app/agenting.py 34.37% 21 Missing :warning:
src/keria/peer/exchanging.py 75.00% 1 Missing :warning:

:x: Your patch check has failed because the patch coverage (67.64%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. :x: Your project check has failed because the head coverage (84.32%) is below the target coverage (85.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   86.60%   84.32%   -2.29%     
==========================================
  Files          25       25              
  Lines        5286     5122     -164     
==========================================
- Hits         4578     4319     -259     
- Misses        708      803      +95     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 06 '25 12:11 codecov[bot]