cesride icon indicating copy to clipboard operation
cesride copied to clipboard

Wasm implementation that works e2e with signify-ts

Open daidoji opened this issue 2 years ago • 5 comments

Rationale

We'd like to use wasm and FFI with signify-ts rather than having a bunch of cesr implementations. This is the first step of showing that's possible.

Testing

Created tests on dater in the signify-ts PR but left this mainly where @DmitryKuzmenko and @jasoncolburne had things set up before. Testing the wasm-artifacts in this repo is something we'll have to figure out.

For Reviewers

Didn't bump because main crate didn't change (although I will open some issues in regards to differences with keripy)

  • [X] Verify version bumped in Cargo.toml

daidoji avatar Nov 29 '23 13:11 daidoji

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7cd5453) 95.42% compared to head (5216cd0) 95.42%.

:exclamation: Current head 5216cd0 differs from pull request most recent head d3ab3d2. Consider uploading reports for the commit d3ab3d2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   95.42%   95.42%           
=======================================
  Files          32       32           
  Lines        3037     3037           
=======================================
  Hits         2898     2898           
  Misses        139      139           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 29 '23 13:11 codecov[bot]

Another thing to do would be make the web tests run in CI, right now I think it just does a sanity build of wasm.

jasoncolburne avatar Dec 10 '23 08:12 jasoncolburne

@jasoncolburne cool. Those are both things I think I can manage. Do you want me to just add them to this PR for a mega-PR or I can split them out into issues and smaller PRs? Mostly I just focused on the Dater implementation and getting that wasm import to work in this signify-ts PR https://github.com/WebOfTrust/signify-ts/pull/149/files

daidoji avatar Dec 12 '23 12:12 daidoji

@jasoncolburne @m00sey Umm messed up the git log a bit because this is a mega-PR but d5a6189 addresses #162

daidoji avatar Dec 18 '23 16:12 daidoji

@jasoncolburne whoops, that'll be the last commit to this branch. In the interests of not having this being a giga-PR that keeps growing and growing I'm gonna take your suggestions in this thread and do a bunch of mini-PRs to the wasm branch in this repo (that should match this PR). Hopefully, that'll help with reviews whenever we get around to wanting to merge this into the main branch.

daidoji avatar Jan 08 '24 15:01 daidoji