WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

Remove longstanding iOS-specific image painting antialiasing quirk

Open hortont424 opened this issue 2 years ago โ€ข 3 comments

ef3ae0b1e9717221ac7c094161fa75cae8fd99b4

Remove longstanding iOS-specific image painting antialiasing quirk
https://bugs.webkit.org/show_bug.cgi?id=246551
rdar://100183888

Reviewed by NOBODY (OOPS!).

* Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContextCG::drawNativeImage):
In the interests of platform unity, remove this longstanding iOS image painting
quirk; it can cause pixel cracks in some cases, and there is no reason for iOS
image painting to differ from macOS at this point (it was originally introduced
for performance on very early hardware).

https://github.com/WebKit/WebKit/commit/ef3ae0b1e9717221ac7c094161fa75cae8fd99b4

Misc iOS, tvOS & watchOS macOS Linux Windows
โœ… ๐Ÿงช style โœ… ๐Ÿ›  ios โœ… ๐Ÿ›  mac โœ… ๐Ÿ›  wpe โœ… ๐Ÿ›  ๐Ÿงช win
โœ… ๐Ÿงช bindings โœ… ๐Ÿ›  ios-sim โœ… ๐Ÿ›  mac-debug โœ… ๐Ÿ›  gtk โœ… ๐Ÿ›  wincairo
โœ… ๐Ÿงช webkitperl โŒ ๐Ÿงช ios-wk2 โœ… ๐Ÿ›  mac-AS-debug โœ… ๐Ÿงช gtk-wk2
โœ… ๐Ÿงช api-ios โœ… ๐Ÿงช api-mac โœ… ๐Ÿงช api-gtk
โœ… ๐Ÿ›  tv โœ… ๐Ÿงช mac-wk1
โœ… ๐Ÿ›  tv-sim โœ… ๐Ÿงช mac-wk2
โœ… ๐Ÿ›  watch โœ… ๐Ÿงช mac-AS-debug-wk2
โœ… ๐Ÿ›  watch-sim โœ… ๐Ÿงช mac-wk2-stress

hortont424 avatar Oct 14 '22 23:10 hortont424

Do you expect zero impact on benchmarks, no chance of 1% regression somewhere?

aproskuryakov avatar Oct 15 '22 03:10 aproskuryakov

Do you expect zero impact on benchmarks, no chance of 1% regression somewhere?

I am going to kick off some benchmarks; first I wanted to see what the tests say.

hortont424 avatar Oct 15 '22 04:10 hortont424

This is a 3-5% motionmark regression, so I will find another way :(

hortont424 avatar Oct 18 '22 18:10 hortont424

Let's extend this quirk to macOS? :)

aproskuryakov avatar Oct 18 '22 19:10 aproskuryakov

Let's extend this quirk to macOS? :)

Definitely not going to regress correctness on macOS for an optimization that should never have landed :) I am going to fix my pixel cracks a different way, and will just leave this be :(

hortont424 avatar Oct 18 '22 20:10 hortont424