WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

Published 20 hours ago • verified publisher icon WebKit

Add check that request's firstPartyForCookies is reasonable

Open achristensen07 opened this issue 2 years ago • 3 comments

457a7e50e6d1d47d99ef4272e8c5a016981165ee

Add check that request's firstPartyForCookies is reasonable
https://bugs.webkit.org/show_bug.cgi?id=246504

Reviewed by NOBODY (OOPS!).

* Source/WebKit/NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::scheduleResourceLoad):

https://github.com/WebKit/WebKit/commit/a51db29654edaf354eda17e83d271f3696bfd389

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ❌ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

achristensen07 avatar Oct 14 '22 05:10 achristensen07

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/457a7e50e6d1d47d99ef4272e8c5a016981165ee)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl   ~~🧪 ios-wk2~~ ✅ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios   ~~🧪 api-mac~~ ❌ 🧪 api-gtk
✅ 🛠 tv   ~~🧪 mac-wk1~~
✅ 🛠 tv-sim ❌ 🧪 mac-wk2
✅ 🛠 watch ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Oct 14 '22 05:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/eacb073c7316f9d95efd596df2f2925ca472869e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ⏳ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl   ~~🧪 ios-wk2~~ ✅ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
  ~~🧪 api-ios~~   ~~🧪 api-mac~~   ~~🧪 api-gtk~~
✅ 🛠 tv   ~~🧪 mac-wk1~~
✅ 🛠 tv-sim   ~~🧪 mac-wk2~~
✅ 🛠 watch   ~~🧪 mac-AS-debug-wk2~~
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Oct 14 '22 18:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/a51db29654edaf354eda17e83d271f3696bfd389)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ❌ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Oct 14 '22 21:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/8672ab616f01782c607c5b722febea295ebeb53f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ❌ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios   ~~🧪 api-mac~~ ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ❌ 🧪 mac-wk2
✅ 🛠 watch ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Oct 20 '22 21:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/0e2481d25dbf878e95fa1a80c2da3581f21cae11)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ⏳ 🛠 mac ✅ 🛠 wpe   ~~🛠 🧪 win~~
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-debug ✅ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl   ~~🧪 ios-wk2~~ ✅ 🛠 mac-AS-debug   ~~🧪 gtk-wk2~~
  ~~🧪 api-ios~~ ⏳ 🧪 api-mac ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ✅ 🛠 tv ⏳ 🧪 mac-wk1
✅ 🛠 tv-sim ⏳ 🧪 mac-wk2
✅ 🛠 watch   ~~🧪 mac-AS-debug-wk2~~
✅ 🛠 watch-sim ⏳ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Oct 21 '22 04:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/529fc6b85c842e52544fc51e4709b1ead269f1c5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk   ~~🛠 wincairo~~
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios   ~~🧪 api-mac~~ ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ❌ 🧪 mac-wk2
✅ 🛠 watch ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Oct 21 '22 06:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/b6385b6104c3eb42822f237d2b9488843c592d52)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ⏳ 🛠 mac-debug ⏳ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ⏳ 🛠 mac-AS-debug ⏳ 🧪 gtk-wk2
⏳ 🧪 api-ios ⏳ 🧪 api-mac ⏳ 🧪 api-gtk
⏳ 🛠 tv ⏳ 🧪 mac-wk1
✅ 🛠 tv-sim ⏳ 🧪 mac-wk2
✅ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ⏳ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Oct 22 '22 00:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/59a7cbcc8468328da5b41fbe0decbb2a46fe2984)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios   ~~🧪 api-mac~~ ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ❌ 🧪 mac-wk2
✅ 🛠 watch ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Oct 22 '22 00:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/642c27a950192be0e5f7546bbc1371c83952afdb)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ❌ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios   ~~🧪 api-mac~~ ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Oct 22 '22 21:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/b10c7b9df8c405dd1a7f66ea23955b82b141a1e0)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ⏳ 🛠 mac ✅ 🛠 wpe   ~~🛠 🧪 win~~
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ⏳ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl   ~~🧪 ios-wk2~~ ⏳ 🛠 mac-AS-debug ⏳ 🧪 gtk-wk2
  ~~🧪 api-ios~~ ⏳ 🧪 api-mac ⏳ 🧪 api-gtk
⏳ 🛠 tv ⏳ 🧪 mac-wk1
⏳ 🛠 tv-sim ⏳ 🧪 mac-wk2
⏳ 🛠 watch ⏳ 🧪 mac-AS-debug-wk2
⏳ 🛠 watch-sim ⏳ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Oct 23 '22 05:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/8c2064e87cded0168dcb77ce70b547cd88f36a6e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 api-mac ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch ✅ 🧪 mac-AS-debug-wk2
❌ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Oct 23 '22 05:10 webkit-early-warning-system

Unable to reproduce the iOS test failure after several attempts in different configurations. cq+

achristensen07 avatar Oct 26 '22 01:10 achristensen07

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/e15470cef8c24273e20b2f0cba7f7d2757e76028)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ❌ 🛠 ios ❌ 🛠 mac ❌ 🛠 wpe ❌ 🛠 🧪 win
❌ 🧪 bindings ❌ 🛠 ios-sim ❌ 🛠 mac-debug ❌ 🛠 gtk ❌ 🛠 wincairo
❌ 🧪 webkitperl ❌ 🧪 ios-wk2 ❌ 🛠 mac-AS-debug ❌ 🧪 gtk-wk2
❌ 🧪 api-ios ❌ 🧪 api-mac ❌ 🧪 api-gtk
❌ 🛠 tv ❌ 🧪 mac-wk1
❌ 🛠 tv-sim ❌ 🧪 mac-wk2
❌ 🛠 watch ❌ 🧪 mac-AS-debug-wk2
❌ 🛠 🧪 unsafe-merge ❌ 🛠 watch-sim ❌ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Oct 26 '22 15:10 webkit-early-warning-system

EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/4287fe3810124c9f840a44f26769fa3f563e064f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   ~~🧪 ios-wk2~~ ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   ~~🧪 api-mac~~ ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk1
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch   ~~🧪 mac-AS-debug-wk2~~
✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Oct 27 '22 00:10 webkit-early-warning-system

EWS run on current version of this PR (hash https://github.com/WebKit/WebKit/commit/286f09aae2660d8958cd50ba5a913ebbe6b9f920)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🛠 mac-AS-debug ✅ 🧪 gtk-wk2
✅ 🧪 api-ios   ~~🧪 api-mac~~ ✅ 🧪 api-gtk
✅ 🛠 tv   ~~🧪 mac-wk1~~
✅ 🛠 tv-sim ✅ 🧪 mac-wk2
✅ 🛠 watch   ~~🧪 mac-AS-debug-wk2~~
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 mac-wk2-stress

webkit-early-warning-system avatar Oct 27 '22 08:10 webkit-early-warning-system

Committed 256065@main (45729b130aab): https://commits.webkit.org/256065@main

Reviewed commits have been landed. Closing PR #5365 and removing active labels.

webkit-commit-queue avatar Oct 27 '22 15:10 webkit-commit-queue