WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

Canvas should be able to draw a WebCodecsVideoFrame

Open youennf opened this issue 2 years ago โ€ข 3 comments

2818372c8d21038f933e5897aec08549f8fed302

Canvas should be able to draw a WebCodecsVideoFrame
https://bugs.webkit.org/show_bug.cgi?id=246392
rdar://problem/101066016

Reviewed by NOBODY (OOPS!).

Make sure to create a correct WebCodecsVideoFrame from canvas.
Update IDL and binding code to allow taking WebCodecsVideoFrame as a CanvasImageSource.
Add prelimianry support to paint a WebCodecsVideoFrame in a canvas.

* LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/webcodecs/videoFrame-canvasImageSource.html:
* Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp:
(WebCore::checkImageUsability):
(WebCore::WebCodecsVideoFrame::create):
(WebCore::WebCodecsVideoFrame::initializeFrameFromOtherFrame):
* Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.h:
(WebCore::WebCodecsVideoFrame::shoudlDiscardAlpha const):
* Source/WebCore/html/canvas/CanvasDrawImage.idl:
* Source/WebCore/html/canvas/CanvasFillStrokeStyles.idl:
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:
(WebCore::size):
(WebCore::CanvasRenderingContext2DBase::drawImage):
(WebCore::CanvasRenderingContext2DBase::createPattern):
* Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:
* Source/WebCore/inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::processArgument):
* Source/WebCore/inspector/InspectorCanvasCallTracer.h:
* Source/WebCore/platform/VideoFrame.cpp:
(WebCore::VideoFrame::paintInContext):
* Source/WebCore/platform/VideoFrame.h:
* Source/WebCore/platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::paintVideoFrame):
* Source/WebCore/platform/graphics/GraphicsContext.h:
* Source/WebCore/platform/graphics/cv/VideoFrameCV.mm:
(WebCore::VideoFrame::paintInContext):
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::paintVideoFrame):
* Source/WebCore/platform/graphics/displaylists/DisplayListRecorder.h:

https://github.com/WebKit/WebKit/commit/89dadfba53b9f2e9e7f9342fab6f0c493bda9cb6

Misc iOS, tvOS & watchOS macOS Linux Windows
โŒ ๐Ÿงช style โœ… ๐Ÿ›  ios โœ… ๐Ÿ›  mac โœ… ๐Ÿ›  wpe โœ… ๐Ÿ›  ๐Ÿงช win
โœ… ๐Ÿงช bindings โœ… ๐Ÿ›  ios-sim โœ… ๐Ÿ›  mac-debug โœ… ๐Ÿ›  gtk โœ… ๐Ÿ›  wincairo
โœ… ๐Ÿงช webkitperl โœ… ๐Ÿงช ios-wk2 โœ… ๐Ÿ›  mac-AS-debug โœ… ๐Ÿงช gtk-wk2
โœ… ๐Ÿงช api-ios โœ… ๐Ÿงช api-mac โœ… ๐Ÿงช api-gtk
โœ… ๐Ÿ›  tv โœ… ๐Ÿงช mac-wk1
โœ… ๐Ÿ›  tv-sim โœ… ๐Ÿงช mac-wk2
โœ… ๐Ÿ›  watch โœ… ๐Ÿงช mac-AS-debug-wk2
โœ… ๐Ÿ›  watch-sim โœ… ๐Ÿงช mac-wk2-stress

youennf avatar Oct 12 '22 06:10 youennf

Committed 255720@main (ed683c9b20ac): https://commits.webkit.org/255720@main

Reviewed commits have been landed. Closing PR #5280 and removing active labels.

webkit-commit-queue avatar Oct 19 '22 08:10 webkit-commit-queue