WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

Remove FontCascade::s_codePath

Open mattwoodrow opened this issue 2 years ago โ€ข 1 comments

49d00d1fff6f05cb7b80c4e41f522ce4f4bfad7c

Remove FontCascade::s_codePath
https://bugs.webkit.org/show_bug.cgi?id=233979

Reviewed by Myles C. Maxfield.

FontCascade::s_codePath can be read on worker threads with
OffscreenCanvas and written on the main thread. Rather than make
it thread safe, let's try removing it. This means:

- Removing the corresponding Debug menu option.
- Removing the --complex-text WKTR/DRT argument.
- Removing support for the --complex-text argument when running tests.
- Removing the WEBKIT_FORCE_COMPLEX_TEXT env variable.

* Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::codePath const):
(WebCore::FontCascade::setCodePath): Deleted.
(WebCore::FontCascade::codePath): Deleted.
* Source/WebCore/platform/graphics/FontCascade.h:
* Source/WebCore/platform/win/WebCoreTextRenderer.cpp:
(WebCore::WebCoreSetAlwaysUsesComplexTextCodePath): Deleted.
(WebCore::WebCoreAlwaysUsesComplexTextCodePath): Deleted.
* Source/WebCore/platform/win/WebCoreTextRenderer.h:
* Source/WebKit/UIProcess/API/C/WKContext.cpp:
(WKContextSetAlwaysUsesComplexTextCodePath): Deleted.
* Source/WebKit/UIProcess/API/C/WKContextPrivate.h:
* Source/WebKit/UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
(WebKit::WebProcessPool::setAlwaysUsesComplexTextCodePath): Deleted.
* Source/WebKit/UIProcess/WebProcessPool.h:
* Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:
(WebKit::WebProcessPool::platformInitialize):
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::setAlwaysUsesComplexTextCodePath): Deleted.
* Source/WebKit/WebProcess/WebProcess.h:
* Source/WebKit/WebProcess/WebProcess.messages.in:
* Source/WebKitLegacy/mac/WebView/WebView.mm:
(+[WebView _setAlwaysUsesComplexTextCodePath:]): Deleted.
* Source/WebKitLegacy/mac/WebView/WebViewPrivate.h:
* Source/WebKitLegacy/win/Interfaces/IWebViewPrivate.idl:
* Source/WebKitLegacy/win/WebView.cpp:
(WebView::setAlwaysUsesComplexTextCodePath): Deleted.
(WebView::alwaysUsesComplexTextCodePath): Deleted.
* Source/WebKitLegacy/win/WebView.h:
* Tools/DumpRenderTree/mac/DumpRenderTree.mm:
(initializeGlobalsFromCommandLineOptions):
(dumpRenderTree):
* Tools/DumpRenderTree/win/DumpRenderTree.cpp:
(createWebViewAndOffscreenWindow):
* Tools/Scripts/webkit-tools-completion.sh:
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.serial_test_check_for_world_leaks):
(RunTest.serial_test_complex_text): Deleted.
* Tools/Scripts/webkitpy/port/driver.py:
(Driver.cmd_line):
* Tools/WebKitTestRunner/Options.cpp:
(WTR::OptionsHandler::OptionsHandler):
(WTR::handleOptionComplexText): Deleted.
* Tools/WebKitTestRunner/Options.h:
* Tools/WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
(WTR::TestController::generatePageConfiguration):

https://github.com/WebKit/WebKit/commit/49d00d1fff6f05cb7b80c4e41f522ce4f4bfad7c

Misc iOS, tvOS & watchOS macOS Linux Windows
โœ… ๐Ÿงช style โœ… ๐Ÿ›  ios โœ… ๐Ÿ›  mac โœ… ๐Ÿ›  wpe โŒ ๐Ÿ›  ๐Ÿงช win
โœ… ๐Ÿงช bindings โœ… ๐Ÿ›  ios-sim โŒ ๐Ÿ›  mac-debug โœ… ๐Ÿ›  gtk โœ… ๐Ÿ›  wincairo
โœ… ๐Ÿงช webkitperl โœ… ๐Ÿงช ios-wk2 โœ… ๐Ÿ›  mac-AS-debug โœ… ๐Ÿงช gtk-wk2
โœ… ๐Ÿงช webkitpy โœ… ๐Ÿงช api-ios โŒ ๐Ÿงช api-mac โœ… ๐Ÿงช api-gtk
โœ… ๐Ÿ›  tv โœ… ๐Ÿงช mac-wk1
โœ… ๐Ÿ›  tv-sim โœ… ๐Ÿงช mac-wk2
โœ… ๐Ÿ›  watch โœ… ๐Ÿงช mac-AS-debug-wk2
โœ… ๐Ÿ›  watch-sim โœ… ๐Ÿงช mac-wk2-stress

mattwoodrow avatar Sep 11 '22 23:09 mattwoodrow