WebKit
WebKit copied to clipboard
Remove FontCascade::s_codePath
49d00d1fff6f05cb7b80c4e41f522ce4f4bfad7c
Remove FontCascade::s_codePath https://bugs.webkit.org/show_bug.cgi?id=233979 Reviewed by Myles C. Maxfield. FontCascade::s_codePath can be read on worker threads with OffscreenCanvas and written on the main thread. Rather than make it thread safe, let's try removing it. This means: - Removing the corresponding Debug menu option. - Removing the --complex-text WKTR/DRT argument. - Removing support for the --complex-text argument when running tests. - Removing the WEBKIT_FORCE_COMPLEX_TEXT env variable. * Source/WebCore/platform/graphics/FontCascade.cpp: (WebCore::FontCascade::codePath const): (WebCore::FontCascade::setCodePath): Deleted. (WebCore::FontCascade::codePath): Deleted. * Source/WebCore/platform/graphics/FontCascade.h: * Source/WebCore/platform/win/WebCoreTextRenderer.cpp: (WebCore::WebCoreSetAlwaysUsesComplexTextCodePath): Deleted. (WebCore::WebCoreAlwaysUsesComplexTextCodePath): Deleted. * Source/WebCore/platform/win/WebCoreTextRenderer.h: * Source/WebKit/UIProcess/API/C/WKContext.cpp: (WKContextSetAlwaysUsesComplexTextCodePath): Deleted. * Source/WebKit/UIProcess/API/C/WKContextPrivate.h: * Source/WebKit/UIProcess/WebProcessPool.cpp: (WebKit::WebProcessPool::initializeNewWebProcess): (WebKit::WebProcessPool::setAlwaysUsesComplexTextCodePath): Deleted. * Source/WebKit/UIProcess/WebProcessPool.h: * Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp: (WebKit::WebProcessPool::platformInitialize): * Source/WebKit/WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess): (WebKit::WebProcess::setAlwaysUsesComplexTextCodePath): Deleted. * Source/WebKit/WebProcess/WebProcess.h: * Source/WebKit/WebProcess/WebProcess.messages.in: * Source/WebKitLegacy/mac/WebView/WebView.mm: (+[WebView _setAlwaysUsesComplexTextCodePath:]): Deleted. * Source/WebKitLegacy/mac/WebView/WebViewPrivate.h: * Source/WebKitLegacy/win/Interfaces/IWebViewPrivate.idl: * Source/WebKitLegacy/win/WebView.cpp: (WebView::setAlwaysUsesComplexTextCodePath): Deleted. (WebView::alwaysUsesComplexTextCodePath): Deleted. * Source/WebKitLegacy/win/WebView.h: * Tools/DumpRenderTree/mac/DumpRenderTree.mm: (initializeGlobalsFromCommandLineOptions): (dumpRenderTree): * Tools/DumpRenderTree/win/DumpRenderTree.cpp: (createWebViewAndOffscreenWindow): * Tools/Scripts/webkit-tools-completion.sh: * Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args): * Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: (RunTest.serial_test_check_for_world_leaks): (RunTest.serial_test_complex_text): Deleted. * Tools/Scripts/webkitpy/port/driver.py: (Driver.cmd_line): * Tools/WebKitTestRunner/Options.cpp: (WTR::OptionsHandler::OptionsHandler): (WTR::handleOptionComplexText): Deleted. * Tools/WebKitTestRunner/Options.h: * Tools/WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): (WTR::TestController::generatePageConfiguration):
https://github.com/WebKit/WebKit/commit/49d00d1fff6f05cb7b80c4e41f522ce4f4bfad7c
https://github.com/WebKit/WebKit/commit/49d00d1fff6f05cb7b80c4e41f522ce4f4bfad7c