WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

Expose signpost feature through performance.mark

Open Constellation opened this issue 2 years ago โ€ข 6 comments

9b6ae7b7c448c1fe2c63892b5c18f87142909709

Expose signpost feature through performance.mark
https://bugs.webkit.org/show_bug.cgi?id=244793

Reviewed by NOBODY (OOPS!).

This patch adds signpost emission feature to performance.mark. Unfortunately, performance.mark does not include "begin" and "end"
information so we need a way to tell the interval through detail optional JS value.
We add "webkitSignpost" handling, and we carefuly retrieve a value without side effect. So while it does not break standards, still
we offer a way to tell how to emit signpost to WebKit.

    performance.mark("marking#1", { detail: { webkitSignpost: "begin" } });
    ...
    measured code.
    ...
    performance.mark("marking#1", { detail: { webkitSignpost: "end" } });

* Source/WebCore/page/PerformanceMark.cpp:
(WebCore::PerformanceMark::create):

https://github.com/WebKit/WebKit/commit/9b6ae7b7c448c1fe2c63892b5c18f87142909709

Misc iOS, tvOS & watchOS macOS Linux Windows
โœ… ๐Ÿงช style โœ… ๐Ÿ›  ios โœ… ๐Ÿ›  mac โœ… ๐Ÿ›  wpe โœ… ๐Ÿ›  ๐Ÿงช win
โœ… ๐Ÿงช bindings โœ… ๐Ÿ›  ios-sim โœ… ๐Ÿ›  mac-debug โœ… ๐Ÿ›  gtk โœ… ๐Ÿ›  wincairo
โœ… ๐Ÿงช webkitperl โœ… ๐Ÿงช ios-wk2 โœ… ๐Ÿ›  mac-AS-debug โœ… ๐Ÿงช gtk-wk2
โœ… ๐Ÿงช api-ios โœ… ๐Ÿงช api-mac โœ… ๐Ÿงช api-gtk
โœ… ๐Ÿ›  tv โœ… ๐Ÿงช mac-wk1
โœ… ๐Ÿ›  tv-sim โœ… ๐Ÿงช mac-wk2
โœ… ๐Ÿ›  watch โœ… ๐Ÿงช mac-AS-debug-wk2
โœ… ๐Ÿ›  watch-sim โœ… ๐Ÿงช mac-wk2-stress

Constellation avatar Sep 05 '22 05:09 Constellation

@Constellation - It seems this reviewed and passing test PR didn't landed. It might need rebase unless if it is not needed anymore.

Ahmad-S792 avatar May 17 '23 14:05 Ahmad-S792