WebKit
WebKit copied to clipboard
Expose signpost feature through performance.mark
9b6ae7b7c448c1fe2c63892b5c18f87142909709
Expose signpost feature through performance.mark https://bugs.webkit.org/show_bug.cgi?id=244793 Reviewed by NOBODY (OOPS!). This patch adds signpost emission feature to performance.mark. Unfortunately, performance.mark does not include "begin" and "end" information so we need a way to tell the interval through detail optional JS value. We add "webkitSignpost" handling, and we carefuly retrieve a value without side effect. So while it does not break standards, still we offer a way to tell how to emit signpost to WebKit. performance.mark("marking#1", { detail: { webkitSignpost: "begin" } }); ... measured code. ... performance.mark("marking#1", { detail: { webkitSignpost: "end" } }); * Source/WebCore/page/PerformanceMark.cpp: (WebCore::PerformanceMark::create):
https://github.com/WebKit/WebKit/commit/9b6ae7b7c448c1fe2c63892b5c18f87142909709
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/6525f351c79f2c3388aa060707049417998634aa)
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/370a75141296d84c1b131ef4dfae7e95d0c1373b)
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/18a2da1b976f9bec9c756308659a7b58750fedbb)
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/1bd913285384dc40c3d9b62cd8bbdeec2d597311)
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/60e1ec7bf2c4506bb7fa1429c3ad3197dc3ef948)
https://github.com/WebKit/WebKit/commit/9b6ae7b7c448c1fe2c63892b5c18f87142909709
@Constellation - It seems this reviewed and passing test PR didn't landed. It might need rebase unless if it is not needed anymore.