WebKit
WebKit copied to clipboard
[WebDriver] Add BiDi webSocketUrl capability
e5d5d48831fc586a74edc2a0251e773a16c4259a
[WebDriver] Add BiDi webSocketUrl capability https://bugs.webkit.org/show_bug.cgi?id=278390 Reviewed by NOBODY (OOPS!). This is a new capability defined by the Webdriver Bidi spec[1]. When the user sends `webSocketUrl==true`, it means the user requested a BiDi session in parallel to the classic session being initiated. This commit adds support for parsing and processing webSocketURL, failing the capability negotiation explictly if the user requested it and we don't support BiDi, which is the case for now, instead of failing as a unknown capability key in WebDriverService::validatedCapabilities(). bug230615 (BiDi session support) will build on top of this to make use of this capability to actually setup BiDi sessions. Note: The platformSupportBidi() definitions are already split among the port-specific files, so each port can enable it individually. [1] https://w3c.github.io/webdriver-bidi/#websocket-url * Source/WebDriver/Capabilities.h: * Source/WebDriver/WebDriverService.cpp: (WebDriver::WebDriverService::parseCapabilities const): (WebDriver::WebDriverService::validatedCapabilities const): (WebDriver::WebDriverService::matchCapabilities const): * Source/WebDriver/WebDriverService.h: * Source/WebDriver/glib/WebDriverServiceGLib.cpp: (WebDriver::WebDriverService::platformSupportBidi const): * Source/WebDriver/playstation/WebDriverServicePlayStation.cpp: (WebDriver::WebDriverService::platformSupportBidi const): * Source/WebDriver/win/WebDriverServiceWin.cpp: (WebDriver::WebDriverService::platformSupportBidi const):
https://github.com/WebKit/WebKit/commit/e5d5d48831fc586a74edc2a0251e773a16c4259a
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/e5d5d48831fc586a74edc2a0251e773a16c4259a)
EWS run on current version of this PR (hash https://github.com/WebKit/WebKit/commit/dca980967ddd7bb4419ff0a5cae77b27ab6162a0)
Committed 283007@main (311f6ee395f7): https://commits.webkit.org/283007@main
Reviewed commits have been landed. Closing PR #32463 and removing active labels.