WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

[WebDriver] Add BiDi webSocketUrl capability

Open lauromoura opened this issue 1 year ago โ€ข 1 comments

e5d5d48831fc586a74edc2a0251e773a16c4259a

[WebDriver] Add BiDi webSocketUrl capability
https://bugs.webkit.org/show_bug.cgi?id=278390

Reviewed by NOBODY (OOPS!).

This is a new capability defined by the Webdriver Bidi spec[1]. When the
user sends `webSocketUrl==true`, it means the user requested a BiDi
session in parallel to the classic session being initiated.

This commit adds support for parsing and processing webSocketURL, failing
the capability negotiation explictly if the user requested it and we don't
support BiDi, which is the case for now, instead of failing as a unknown
capability key in WebDriverService::validatedCapabilities().

bug230615 (BiDi session support) will build on top of this to make use of
this capability to actually setup BiDi sessions.

Note: The platformSupportBidi() definitions are already split among the
port-specific files, so each port can enable it individually.

[1] https://w3c.github.io/webdriver-bidi/#websocket-url

* Source/WebDriver/Capabilities.h:
* Source/WebDriver/WebDriverService.cpp:
(WebDriver::WebDriverService::parseCapabilities const):
(WebDriver::WebDriverService::validatedCapabilities const):
(WebDriver::WebDriverService::matchCapabilities const):
* Source/WebDriver/WebDriverService.h:
* Source/WebDriver/glib/WebDriverServiceGLib.cpp:
(WebDriver::WebDriverService::platformSupportBidi const):
* Source/WebDriver/playstation/WebDriverServicePlayStation.cpp:
(WebDriver::WebDriverService::platformSupportBidi const):
* Source/WebDriver/win/WebDriverServiceWin.cpp:
(WebDriver::WebDriverService::platformSupportBidi const):

https://github.com/WebKit/WebKit/commit/e5d5d48831fc586a74edc2a0251e773a16c4259a

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
โœ… ๐Ÿงช style โœ… ๐Ÿ›  ios โœ… ๐Ÿ›  mac โœ… ๐Ÿ›  wpe โœ… ๐Ÿ›  wincairo
โœ… ๐Ÿ›  ios-sim โœ… ๐Ÿ›  mac-AS-debug โœ… ๐Ÿงช wpe-wk2 โœ… ๐Ÿงช wincairo-tests
โœ… ๐Ÿงช webkitperl โœ… ๐Ÿงช ios-wk2 โœ… ๐Ÿงช api-mac โœ… ๐Ÿงช api-wpe
โœ… ๐Ÿงช ios-wk2-wpt โœ… ๐Ÿงช mac-wk1 โœ… ๐Ÿ›  wpe-cairo
โœ… ๐Ÿงช api-ios โœ… ๐Ÿงช mac-wk2 โœ… ๐Ÿ›  gtk
โœ… ๐Ÿ›  vision โŒ ๐Ÿงช mac-AS-debug-wk2 โœ… ๐Ÿงช gtk-wk2
โœ… ๐Ÿ›  vision-sim โœ… ๐Ÿงช mac-wk2-stress โœ… ๐Ÿงช api-gtk
โœ… ๐Ÿงช vision-wk2
โœ… ๐Ÿ›  tv
โœ… ๐Ÿ›  tv-sim
โœ… ๐Ÿ›  watch
โœ… ๐Ÿ›  watch-sim

lauromoura avatar Aug 20 '24 17:08 lauromoura

Committed 283007@main (311f6ee395f7): https://commits.webkit.org/283007@main

Reviewed commits have been landed. Closing PR #32463 and removing active labels.

webkit-commit-queue avatar Aug 31 '24 01:08 webkit-commit-queue