WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

[css-ui-4] Transparent accent colors (275767)

Open lilyspiniolas opened this issue 1 year ago โ€ข 6 comments

0fd19238487fa926dd52b8de9c830e2f653882c4

[css-ui-4] Transparent accent colors (275767)
https://bugs.webkit.org/show_bug.cgi?id=275767
rdar://130599744

Reviewed by NOBODY (OOPS!).

Transparent accent-colors are now precomposed over the canvas to conform to https://github.com/w3c/csswg-drafts/issues/9852#issuecomment-2166096835.

* Source/WebCore/rendering/RenderTheme.cpp:
(WebCore::RenderTheme::extractControlStyleForRenderer const):
* Source/WebCore/rendering/ios/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::adjustButtonLikeControlStyle const):
(WebCore::RenderThemeIOS::controlTintColor const):
* Source/WebCore/rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::usedAccentColor const):
* Source/WebCore/rendering/style/RenderStyle.h:

https://github.com/WebKit/WebKit/commit/0fd19238487fa926dd52b8de9c830e2f653882c4

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
โœ… ๐Ÿงช style โœ… ๐Ÿ›  ios โœ… ๐Ÿ›  mac โœ… ๐Ÿ›  wpe โœ… ๐Ÿ›  wincairo
โœ… ๐Ÿงช bindings โœ… ๐Ÿ›  ios-sim โœ… ๐Ÿ›  mac-AS-debug โœ… ๐Ÿงช wpe-wk2 โœ… ๐Ÿงช wincairo-tests
โœ… ๐Ÿงช webkitperl โœ… ๐Ÿงช ios-wk2 โœ… ๐Ÿงช api-mac โœ… ๐Ÿงช api-wpe
โœ… ๐Ÿงช ios-wk2-wpt โœ… ๐Ÿงช mac-wk1 โœ… ๐Ÿ›  wpe-cairo
โœ… ๐Ÿงช api-ios โœ… ๐Ÿงช mac-wk2 โœ… ๐Ÿ›  gtk
โœ… ๐Ÿ›  vision โœ… ๐Ÿงช mac-AS-debug-wk2 โœ… ๐Ÿงช gtk-wk2
โœ… ๐Ÿ›  vision-sim โœ… ๐Ÿงช mac-wk2-stress โœ… ๐Ÿงช api-gtk
โœ… ๐Ÿงช vision-wk2
โœ… ๐Ÿ›  tv
โœ… ๐Ÿ›  tv-sim
โœ… ๐Ÿ›  watch
โœ… ๐Ÿ›  watch-sim

lilyspiniolas avatar Jul 01 '24 21:07 lilyspiniolas

Generally, we'd also want to see some test changes in this PR. However, I know you've been working upstream to fix the tests. Let's just make sure we do a re-import soon.

pxlcoder avatar Jul 01 '24 21:07 pxlcoder

Fixed suggestions in https://github.com/WebKit/WebKit/commit/0fd19238487fa926dd52b8de9c830e2f653882c4 @nt1m @pxlcoder @rr-codes

lilyspiniolas avatar Jul 02 '24 00:07 lilyspiniolas

@nt1m Added the transparent accent color wpt tests in latest commit

lilyspiniolas avatar Jul 02 '24 17:07 lilyspiniolas

Latest commit increases totalPixels in the fuzzy tag to account for larger controls on mobile devices.

lilyspiniolas avatar Jul 02 '24 23:07 lilyspiniolas

Committed 280631@main (65d8059e3250): https://commits.webkit.org/280631@main

Reviewed commits have been landed. Closing PR #30359 and removing active labels.

webkit-commit-queue avatar Jul 03 '24 18:07 webkit-commit-queue