WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

Add `onbegin` event in `SVGAnimationElement.idl`

Open Ahmad-S792 opened this issue 1 year ago โ€ข 1 comments

Add `onbegin` event in `SVGAnimationElement.idl`
https://bugs.webkit.org/show_bug.cgi?id=275669

Reviewed by NOBODY (OOPS!).

This patch adds 'onbegin' event in 'SVGAnimationElement' IDL interface as per web specification [1]:

[1] https://svgwg.org/specs/animations/#InterfaceSVGAnimationElement

Additionally, it syncs WPT test for coverage from below:

Upstream commit: https://github.com/web-platform-tests/wpt/commit/ba3f63dd69d2d3be6e71c023bca014dc272feb94

* Source/WebCore/dom/EventNames.json:
* Source/WebCore/svg/SVGAnimationElement.idl:
* LayoutTests/imported/w3c/web-platform-tests/svg/idlharness.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/idlharness.window.js:

https://github.com/WebKit/WebKit/commit/4aa4a058407edac5998b5956530463e283b1b0db

Misc iOS, visionOS, tvOS & watchOS macOS Linux Windows
โœ… ๐Ÿงช style โœ… ๐Ÿ›  ios โœ… ๐Ÿ›  mac โœ… ๐Ÿ›  wpe โœ… ๐Ÿ›  wincairo
โœ… ๐Ÿงช bindings โœ… ๐Ÿ›  ios-sim โœ… ๐Ÿ›  mac-AS-debug โœ… ๐Ÿงช wpe-wk2 โœ… ๐Ÿงช wincairo-tests
โœ… ๐Ÿงช webkitperl โœ… ๐Ÿงช ios-wk2 โœ… ๐Ÿงช api-mac โœ… ๐Ÿงช api-wpe
โœ… ๐Ÿงช ios-wk2-wpt โœ… ๐Ÿงช mac-wk1 โœ… ๐Ÿ›  wpe-cairo
โœ… ๐Ÿงช api-ios โœ… ๐Ÿงช mac-wk2 โœ… ๐Ÿ›  gtk
โณ ๐Ÿ›  vision โœ… ๐Ÿงช mac-AS-debug-wk2 โœ… ๐Ÿงช gtk-wk2
โณ ๐Ÿ›  vision-sim โœ… ๐Ÿงช mac-wk2-stress โŒ ๐Ÿงช api-gtk
โณ ๐Ÿงช vision-wk2
โœ… ๐Ÿ›  tv
โœ… ๐Ÿ›  tv-sim
โœ… ๐Ÿ›  watch
โœ… ๐Ÿ›  watch-sim

Ahmad-S792 avatar Jun 19 '24 18:06 Ahmad-S792

Safer C++ Build #1177

:x: Found 1 new failure. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. (cc @rniwa)

webkit-ews-buildbot avatar Oct 11 '24 04:10 webkit-ews-buildbot

When rebasing this and bringing it up-to-date it's worth being aware that this might lead to an issue with TT (See https://bugs.webkit.org/show_bug.cgi?id=286916) Effectively we might need to special case onbegin, onend and onrepeat because the event names don't properly match the IDL and content attributes.

lukewarlow avatar Feb 03 '25 18:02 lukewarlow

regarding the discard element: https://groups.google.com/a/mozilla.org/g/dev-platform/c/w5oCkquDC9E we will be shipping this so we'd prefer it not be removed from the WPT.

longsonr avatar Feb 06 '25 12:02 longsonr

Committed 299724@main (db45fa396ca7): https://commits.webkit.org/299724@main

Reviewed commits have been landed. Closing PR #29984 and removing active labels.

webkit-commit-queue avatar Sep 08 '25 23:09 webkit-commit-queue