Add `onbegin` event in `SVGAnimationElement.idl`
Add `onbegin` event in `SVGAnimationElement.idl` https://bugs.webkit.org/show_bug.cgi?id=275669 Reviewed by NOBODY (OOPS!). This patch adds 'onbegin' event in 'SVGAnimationElement' IDL interface as per web specification [1]: [1] https://svgwg.org/specs/animations/#InterfaceSVGAnimationElement Additionally, it syncs WPT test for coverage from below: Upstream commit: https://github.com/web-platform-tests/wpt/commit/ba3f63dd69d2d3be6e71c023bca014dc272feb94 * Source/WebCore/dom/EventNames.json: * Source/WebCore/svg/SVGAnimationElement.idl: * LayoutTests/imported/w3c/web-platform-tests/svg/idlharness.window-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/svg/idlharness.window.js:
https://github.com/WebKit/WebKit/commit/4aa4a058407edac5998b5956530463e283b1b0db
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/4aa4a058407edac5998b5956530463e283b1b0db)
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/338bf1c0f35c2889bd1474de9a1b284628c6081c)
Safer C++ Build #1177
:x: Found 1 new failure. Please address these issues before landing. See WebKit Guidelines for Safer C++ Programming. (cc @rniwa)
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/0c02028a384aa40024b473b9bdb8bfd3ad857aca)
When rebasing this and bringing it up-to-date it's worth being aware that this might lead to an issue with TT (See https://bugs.webkit.org/show_bug.cgi?id=286916) Effectively we might need to special case onbegin, onend and onrepeat because the event names don't properly match the IDL and content attributes.
regarding the discard element: https://groups.google.com/a/mozilla.org/g/dev-platform/c/w5oCkquDC9E we will be shipping this so we'd prefer it not be removed from the WPT.
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/9d5571d27d564dc460ffdb378aea356333b78f34)
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/4cbe36b8fcc76a76ed4c38a00e6d9b30096fd292)
| Misc | iOS, visionOS, tvOS & watchOS | macOS | Linux | Windows | Apple Internal |
|---|---|---|---|---|---|
| โ ๐งช style | โ ๐ ios | โ ๐ mac | โ ๐ wpe | โ ๐ win | โณ ๐ ios-apple |
| โ ๐งช bindings | โ ๐ ios-sim | โ ๐ mac-AS-debug | โ ๐งช wpe-wk2 | โณ ๐งช win-tests | โณ ๐ mac-apple |
| โ ๐งช webkitperl | โ ๐งช ios-wk2 | โ ๐งช api-mac | โ ๐งช api-wpe | โณ ๐ vision-apple | |
| โ ๐งช ios-wk2-wpt | โ ๐งช mac-wk1 | โ ๐ wpe-cairo | |||
| โ ๐งช api-ios | โ ๐งช mac-wk2 | โ ๐ gtk | |||
| โ ๐ vision | โ ๐งช mac-AS-debug-wk2 | โ ๐งช gtk-wk2 | |||
| โ ๐ vision-sim | โ ๐งช mac-wk2-stress | โ ๐งช api-gtk | |||
| โ ๐งช vision-wk2 | โ ๐งช mac-intel-wk2 | โ ๐ playstation | |||
| โ ๐ tv | โ ๐ mac-safer-cpp | ||||
| โ ๐ tv-sim | |||||
| โ ๐ watch | |||||
| โ ๐ watch-sim |
EWS run on current version of this PR (hash https://github.com/WebKit/WebKit/commit/c422b189ed332095294bbdbc18c857c3b2890bc3)
Committed 299724@main (db45fa396ca7): https://commits.webkit.org/299724@main
Reviewed commits have been landed. Closing PR #29984 and removing active labels.
๐งช api-ios