WebKit icon indicating copy to clipboard operation
WebKit copied to clipboard

[git-webkit] Handle core.hooksPath

Open JonWBedard opened this issue 9 months ago โ€ข 1 comments

174630babc131ab4b38d5c3bca325e943d4c81b8

[git-webkit] Handle core.hooksPath
https://bugs.webkit.org/show_bug.cgi?id=274260
rdar://128152670

Reviewed by NOBODY (OOPS!).

git doesn't always look for hooks in .git/hooks. We should handle the
case where core.hooksPath points somewhere else.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py:
(InstallHooks.hook_needs_update): Check core.hooksPath for the specified hook.
(InstallHooks.main): Check if core.hooksPath matches the expected repository
hook location. If it doesn't, prompt the user for possible corrective actions.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_hooks_unittest.py:
(TestInstallHooks.test_install_hook_alternate_hook_path_change):
(TestInstallHooks.test_install_hook_alternate_hook_path_use):
(TestInstallHooks.test_install_hook_alternate_hook_path_exit):

https://github.com/WebKit/WebKit/commit/174630babc131ab4b38d5c3bca325e943d4c81b8

Misc iOS, tvOS & watchOS macOS Linux Windows
โœ… ๐Ÿงช style โœ… ๐Ÿ›  ios โœ… ๐Ÿ›  mac โœ… ๐Ÿ›  wpe โœ… ๐Ÿ›  wincairo
โœ… ๐Ÿงช bindings โœ… ๐Ÿ›  ios-sim โœ… ๐Ÿ›  mac-AS-debug โœ… ๐Ÿงช wpe-wk2
โœ… ๐Ÿงช webkitperl โœ… ๐Ÿงช ios-wk2 โœ… ๐Ÿงช api-mac โœ… ๐Ÿงช api-wpe
โœ… ๐Ÿงช webkitpy โœ… ๐Ÿงช ios-wk2-wpt โœ… ๐Ÿงช mac-wk1 โณ ๐Ÿ›  wpe-skia
โœ… ๐Ÿงช api-ios โœ… ๐Ÿงช mac-wk2 โœ… ๐Ÿ›  gtk
โœ… ๐Ÿ›  tv โœ… ๐Ÿงช mac-AS-debug-wk2 โœ… ๐Ÿงช gtk-wk2
โœ… ๐Ÿงช services โœ… ๐Ÿ›  tv-sim โœ… ๐Ÿงช mac-wk2-stress โœ… ๐Ÿงช api-gtk
โœ… ๐Ÿ›  watch
โœ… ๐Ÿ›  watch-sim

JonWBedard avatar May 16 '24 15:05 JonWBedard

I've confirmed this correctly identifies the expectation mismatch, and the suggested/default fix correctly sets the hook dir for the repo, and doesn't conflict with global rules

ojhunt avatar May 16 '24 23:05 ojhunt

Committed 278921@main (a60827c76f1d): https://commits.webkit.org/278921@main

Reviewed commits have been landed. Closing PR #28654 and removing active labels.

webkit-commit-queue avatar May 17 '24 18:05 webkit-commit-queue