WebKit
WebKit copied to clipboard
[git-webkit] Handle core.hooksPath
174630babc131ab4b38d5c3bca325e943d4c81b8
[git-webkit] Handle core.hooksPath https://bugs.webkit.org/show_bug.cgi?id=274260 rdar://128152670 Reviewed by NOBODY (OOPS!). git doesn't always look for hooks in .git/hooks. We should handle the case where core.hooksPath points somewhere else. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py: (InstallHooks.hook_needs_update): Check core.hooksPath for the specified hook. (InstallHooks.main): Check if core.hooksPath matches the expected repository hook location. If it doesn't, prompt the user for possible corrective actions. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_hooks_unittest.py: (TestInstallHooks.test_install_hook_alternate_hook_path_change): (TestInstallHooks.test_install_hook_alternate_hook_path_use): (TestInstallHooks.test_install_hook_alternate_hook_path_exit):
https://github.com/WebKit/WebKit/commit/174630babc131ab4b38d5c3bca325e943d4c81b8
EWS run on previous version of this PR (hash https://github.com/WebKit/WebKit/commit/174630babc131ab4b38d5c3bca325e943d4c81b8)
EWS run on current version of this PR (hash https://github.com/WebKit/WebKit/commit/52354df7d9e8f5ec9cb807d8a4835c796eaee9a7)
I've confirmed this correctly identifies the expectation mismatch, and the suggested/default fix correctly sets the hook dir for the repo, and doesn't conflict with global rules
Committed 278921@main (a60827c76f1d): https://commits.webkit.org/278921@main
Reviewed commits have been landed. Closing PR #28654 and removing active labels.